Fix: Fixed issue where Details/Preview Pane didn't update when switching tabs (#12975)

hishitetsu · web-flow · commit b5b2150fea0b · 2023-07-18T22:13:44.000-04:00
diff --git a/src/Files.App/Views/LayoutModes/BaseLayout.cs b/src/Files.App/Views/LayoutModes/BaseLayout.cs
@@ -1377,6 +1377,11 @@ await DispatcherQueue.EnqueueOrInvokeAsync(() =>
 			}
 		}
 
+		public void ReloadPreviewPane()
+		{
+			UpdatePreviewPaneSelection(SelectedItems);
+		}
+
 		protected void UpdatePreviewPaneSelection(List<ListedItem>? value)
 		{
 			if (LockPreviewPaneContent)
diff --git a/src/Files.App/Views/LayoutModes/IBaseLayout.cs b/src/Files.App/Views/LayoutModes/IBaseLayout.cs
@@ -36,5 +36,7 @@ public interface IBaseLayout : IDisposable
 		CommandBarFlyout ItemContextMenuFlyout { get; set; }
 
 		CommandBarFlyout BaseContextMenuFlyout { get; set; }
+
+		void ReloadPreviewPane();
 	}
 }
diff --git a/src/Files.App/Views/MainPage.xaml.cs b/src/Files.App/Views/MainPage.xaml.cs
@@ -163,6 +163,8 @@ public void MultitaskingControl_CurrentInstanceChanged(object? sender, CurrentIn
 
 			e.CurrentInstance.ContentChanged -= TabItemContent_ContentChanged;
 			e.CurrentInstance.ContentChanged += TabItemContent_ContentChanged;
+
+			SidebarAdaptiveViewModel.PaneHolder?.ActivePaneOrColumn.SlimContentPage?.ReloadPreviewPane();
 		}
 
 		private void PaneHolder_PropertyChanged(object? sender, PropertyChangedEventArgs e)

Original file line number	Diff line number	Diff line change
`@@ -1377,6 +1377,11 @@ await DispatcherQueue.EnqueueOrInvokeAsync(() =>`
`1377`	`1377`	`}`
`1378`	`1378`	`}`
`1379`	`1379`
	`1380`	`+ public void ReloadPreviewPane()`
	`1381`	`+ {`
	`1382`	`+ UpdatePreviewPaneSelection(SelectedItems);`
	`1383`	`+ }`
	`1384`	`+`
`1380`	`1385`	`protected void UpdatePreviewPaneSelection(List<ListedItem>? value)`
`1381`	`1386`	`{`
`1382`	`1387`	`if (LockPreviewPaneContent)`
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,7 @@ public interface IBaseLayout : IDisposable`
`36`	`36`	`CommandBarFlyout ItemContextMenuFlyout { get; set; }`
`37`	`37`
`38`	`38`	`CommandBarFlyout BaseContextMenuFlyout { get; set; }`
	`39`	`+`
	`40`	`+ void ReloadPreviewPane();`
`39`	`41`	`}`
`40`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,8 @@ public void MultitaskingControl_CurrentInstanceChanged(object? sender, CurrentIn`
`163`	`163`
`164`	`164`	`e.CurrentInstance.ContentChanged -= TabItemContent_ContentChanged;`
`165`	`165`	`e.CurrentInstance.ContentChanged += TabItemContent_ContentChanged;`
	`166`	`+`
	`167`	`+ SidebarAdaptiveViewModel.PaneHolder?.ActivePaneOrColumn.SlimContentPage?.ReloadPreviewPane();`
`166`	`168`	`}`
`167`	`169`
`168`	`170`	`private void PaneHolder_PropertyChanged(object? sender, PropertyChangedEventArgs e)`