Fix: Fixed issue where properties were sometimes not displayed in the details pane (#12952)

Author: hishitetsu

src/Files.App/ViewModels/UserControls/PreviewPaneViewModel.cs

@@ -14,8 +14,6 @@ namespace Files.App.ViewModels.UserControls
 {
 	public class PreviewPaneViewModel : ObservableObject, IDisposable
 	{
-		private readonly IUserSettingsService userSettingsService;
-
 		private readonly IPreviewPaneSettingsService previewSettingsService;
 
 		private readonly IContentPageContext contentPageContextService;
@@ -69,16 +67,14 @@ public UIElement PreviewPaneContent
 			set => SetProperty(ref previewPaneContent, value);
 		}
 
-		public PreviewPaneViewModel(IUserSettingsService userSettings, IPreviewPaneSettingsService previewSettings, IContentPageContext contentPageContextService = null)
+		public PreviewPaneViewModel(IPreviewPaneSettingsService previewSettings, IContentPageContext contentPageContextService = null)
 		{
-			userSettingsService = userSettings;
 			previewSettingsService = previewSettings;
 
 			ShowPreviewOnlyInvoked = new RelayCommand(async () => await UpdateSelectedItemPreview());
 
 			IsEnabled = previewSettingsService.IsEnabled;
 
-			userSettingsService.OnSettingChangedEvent += UserSettingsService_OnSettingChangedEvent;
 			previewSettingsService.PropertyChanged += PreviewSettingsService_OnPropertyChangedEvent;
 
 			this.contentPageContextService = contentPageContextService ?? Ioc.Default.GetRequiredService<IContentPageContext>();
@@ -313,18 +309,14 @@ public async Task UpdateSelectedItemPreview(bool downloadItem = false)
 
 		public ICommand ShowPreviewOnlyInvoked { get; }
 
-		private async void UserSettingsService_OnSettingChangedEvent(object sender, SettingChangedEventArgs e)
+		private async void PreviewSettingsService_OnPropertyChangedEvent(object sender, PropertyChangedEventArgs e)
 		{
-			if (e.SettingName is nameof(IPreviewPaneSettingsService.ShowPreviewOnly))
+			if (e.PropertyName is nameof(IPreviewPaneSettingsService.ShowPreviewOnly))
 			{
 				// The preview will need refreshing as the file details won't be accurate
 				await UpdateSelectedItemPreview();
 			}
-		}
-
-		private void PreviewSettingsService_OnPropertyChangedEvent(object sender, PropertyChangedEventArgs e)
-		{
-			if (e.PropertyName is nameof(IPreviewPaneSettingsService.IsEnabled))
+			else if (e.PropertyName is nameof(IPreviewPaneSettingsService.IsEnabled))
 			{
 				var newEnablingStatus = previewSettingsService.IsEnabled;
 				if (isEnabled != newEnablingStatus)
@@ -353,7 +345,6 @@ private async Task LoadBasicPreviewAsync()
 
 		public void Dispose()
 		{
-			userSettingsService.OnSettingChangedEvent -= UserSettingsService_OnSettingChangedEvent;
 			previewSettingsService.PropertyChanged -= PreviewSettingsService_OnPropertyChangedEvent;
 		}
 	}