Skip to content

Commit bce7524

Browse files
authored
Fix crash on startup by providing a migration path for DefaultTerminalPath property (#996)
* Provide a migration path for DefaultTerminalPath property, preventing access when null * Increment Version Number to v0.10.1
1 parent 62abaee commit bce7524

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Files.Package/Package.appxmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
xmlns:uap4="http://schemas.microsoft.com/appx/manifest/uap/windows10/4"
1010
xmlns:uap5="http://schemas.microsoft.com/appx/manifest/uap/windows10/5"
1111
IgnorableNamespaces="uap uap5 mp rescap desktop4 desktop">
12-
<Identity Name="FilesUWPDev" Publisher="CN=53EC4384-7F5B-4CF6-8C23-513FFE9D1AB7" Version="0.10.0.0" />
12+
<Identity Name="FilesUWPDev" Publisher="CN=53EC4384-7F5B-4CF6-8C23-513FFE9D1AB7" Version="0.10.1.0" />
1313
<Properties>
1414
<DisplayName>Files UWP - Dev</DisplayName>
1515
<PublisherDisplayName>Yair A</PublisherDisplayName>

Files/DataModels/TerminalFileModel.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ public async Task<bool> AddOrRemoveTerminal(TerminalModel terminal, string packa
5050
}
5151
else if (!isInstalled)
5252
{
53-
if (DefaultTerminalPath.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase))
53+
if (string.IsNullOrWhiteSpace(DefaultTerminalPath))
54+
{
55+
ResetToDefaultTerminal();
56+
}
57+
else if (DefaultTerminalPath.Equals(terminal.Path, StringComparison.OrdinalIgnoreCase))
5458
{
5559
ResetToDefaultTerminal();
5660
}

0 commit comments

Comments
 (0)