Feature: Added support for hiding the edit tags menu (#11133)

Author: yaira2

src/Files.App/BaseLayout.cs

@@ -623,6 +623,11 @@ private void AddNewFileTagsToMenu(CommandBarFlyout contextMenu)
 			var overflowSeparator = contextMenu.SecondaryCommands.FirstOrDefault(x => x is FrameworkElement fe && fe.Tag as string == "OverflowSeparator") as AppBarSeparator;
 			var index = contextMenu.SecondaryCommands.IndexOf(overflowSeparator);
 			index = index >= 0 ? index : contextMenu.SecondaryCommands.Count;
+
+			// Only show the edit tags flyout if settings is enabled
+			if (!UserSettingsService.AppearanceSettingsService.DisplayEditTagsMenu)
+				return;
+
 			contextMenu.SecondaryCommands.Insert(index, new AppBarSeparator());
 			contextMenu.SecondaryCommands.Insert(index + 1, new AppBarButton()
 			{

src/Files.App/ServicesImplementation/Settings/AppearanceSettingsService.cs

@@ -26,12 +26,6 @@ public bool IsSidebarOpen
 			set => Set(value);
 		}
 
-		public bool MoveShellExtensionsToSubMenu
-		{
-			get => Get(true);
-			set => Set(value);
-		}
-
 		public bool UseCompactStyles
 		{
 			get => Get(false);
@@ -73,16 +67,29 @@ public String AppThemeFontFamily
 			set => Set(value);
 		}
 
+		public bool MoveShellExtensionsToSubMenu
+		{
+			get => Get(true);
+			set => Set(value);
+		}
+
+		public bool DisplayEditTagsMenu
+		{
+			get => Get(true);
+			set => Set(value);
+		}
+
 		protected override void RaiseOnSettingChangedEvent(object sender, SettingChangedEventArgs e)
 		{
 			switch (e.SettingName)
 			{
-				case nameof(MoveShellExtensionsToSubMenu):
 				case nameof(UseCompactStyles):
 				case nameof(AppThemeBackgroundColor):
 				case nameof(AppThemeAddressBarBackgroundColor):
 				case nameof(AppThemeSidebarBackgroundColor):
 				case nameof(AppThemeFileAreaBackgroundColor):
+				case nameof(MoveShellExtensionsToSubMenu):
+				case nameof(DisplayEditTagsMenu):
 					Analytics.TrackEvent($"Set {e.SettingName} to {e.NewValue}");
 					break;
 			}

src/Files.App/Strings/en-US/Resources.resw

@@ -823,7 +823,7 @@
     <value>Language</value>
   </data>
   <data name="SettingsContextMenuOverflow" xml:space="preserve">
-    <value>Move overflow items into a sub menu</value>
+    <value>Move shell extensions into a sub menu</value>
   </data>
   <data name="ShowConfirmationWhenDeletingItems" xml:space="preserve">
     <value>Show confirmation dialog when deleting items</value>
@@ -2898,4 +2898,7 @@
   <data name="BundlesBeingRemovedTitle" xml:space="preserve">
     <value>Bundles will be retiring in a future update 📎</value>
   </data>
-</root>
+  <data name="DisplayEditTagsMenu" xml:space="preserve">
+    <value>Display the edit tags flyout</value>
+  </data>
+</root>

src/Files.App/ViewModels/SettingsViewModels/AppearanceViewModel.cs

@@ -107,6 +107,19 @@ public bool MoveShellExtensionsToSubMenu
 				}
 			}
 		}
+		
+		public bool DisplayEditTagsMenu
+		{
+			get => UserSettingsService.AppearanceSettingsService.DisplayEditTagsMenu;
+			set
+			{
+				if (value != UserSettingsService.AppearanceSettingsService.DisplayEditTagsMenu)
+				{
+					UserSettingsService.AppearanceSettingsService.DisplayEditTagsMenu = value;
+					OnPropertyChanged();
+				}
+			}
+		}
 
 		public bool UseCompactStyles
 		{

src/Files.App/Views/SettingsPages/Appearance.xaml

@@ -175,6 +175,17 @@
 				FontWeight="Medium"
 				Text="{helpers:ResourceString Name=SettingsContextMenu/Text}" />
 
+			<!--  Edit tags  -->
+			<local:SettingsBlockControl Title="{helpers:ResourceString Name=DisplayEditTagsMenu}" HorizontalAlignment="Stretch">
+				<local:SettingsBlockControl.Icon>
+					<FontIcon Glyph="&#xE1CB;" />
+				</local:SettingsBlockControl.Icon>
+				<ToggleSwitch
+					AutomationProperties.Name="{helpers:ResourceString Name=DisplayEditTagsMenu}"
+					IsOn="{x:Bind ViewModel.DisplayEditTagsMenu, Mode=TwoWay}"
+					Style="{StaticResource RightAlignedToggleSwitchStyle}" />
+			</local:SettingsBlockControl>
+			
 			<!--  Overflow Options  -->
 			<local:SettingsBlockControl Title="{helpers:ResourceString Name=SettingsContextMenuOverflow}" HorizontalAlignment="Stretch">
 				<local:SettingsBlockControl.Icon>

src/Files.Backend/Services/Settings/IAppearanceSettingsService.cs

@@ -5,11 +5,6 @@ namespace Files.Backend.Services.Settings
 {
 	public interface IAppearanceSettingsService : IBaseSettingsService, INotifyPropertyChanged
 	{
-		/// <summary>
-		/// Gets or sets a value indicating whether or not to move shell extensions into a sub menu.
-		/// </summary>
-		bool MoveShellExtensionsToSubMenu { get; set; }
-
 		#region Internal Settings
 
 		/// <summary>
@@ -53,5 +48,15 @@ public interface IAppearanceSettingsService : IBaseSettingsService, INotifyPrope
 		/// Gets or sets a value for the app theme font family.
 		/// </summary>
 		String AppThemeFontFamily { get; set; }
+		
+		/// <summary>
+		/// Gets or sets a value indicating whether or not to move shell extensions into a sub menu.
+		/// </summary>
+		bool MoveShellExtensionsToSubMenu { get; set; }
+
+		/// <summary>
+		/// Gets or sets a value indicating whether or not to show the edit tags menu.
+		/// </summary>
+		bool DisplayEditTagsMenu { get; set; }
 	}
 }