Fix: Fixed issue where the Recycle Bin was sometimes unpinned (#16880)

Author: marcofranzen99

src/Files.App/Services/Windows/WindowsQuickAccessService.cs

@@ -26,7 +26,12 @@ public async Task<IEnumerable<ShellFileItem>> GetPinnedFoldersAsync()
 		private async Task PinToSidebarAsync(string[] folderPaths, bool doUpdateQuickAccessWidget)
 		{
 			foreach (string folderPath in folderPaths)
-				await ContextMenu.InvokeVerb("pintohome", [folderPath]);
+			{
+				// make sure that the item has not yet been pinned
+				// the verb 'pintohome' is for both adding and removing
+				if (!IsItemPinned(folderPath))
+					await ContextMenu.InvokeVerb("pintohome", folderPath);
+			}
 
 			await App.QuickAccessManager.Model.LoadAsync();
 			if (doUpdateQuickAccessWidget)

src/Files.App/Utils/Global/QuickAccessManager.cs

@@ -42,11 +42,10 @@ private void PinnedItemsWatcher_Changed(object sender, FileSystemEventArgs e)
 		public async Task InitializeAsync()
 		{
 			PinnedItemsModified += Model.LoadAsync;
+			await Model.LoadAsync();
 
 			if (!Model.PinnedFolders.Contains(Constants.UserEnvironmentPaths.RecycleBinPath) && AppLifecycleHelper.IsFirstRun)
 				await QuickAccessService.PinToSidebarAsync(Constants.UserEnvironmentPaths.RecycleBinPath);
-
-			await Model.LoadAsync();
 		}
 	}
 }