Codebase: Remove unnecessary this keyword (#11037)

Author: hecksmosis

src/Files.App.Storage/WindowsStorage/WindowsStorable.cs

@@ -24,9 +24,9 @@ public abstract class WindowsStorable<TStorage> : ILocatableStorable
 		protected internal WindowsStorable(TStorage storage)
 		{
 			this.storage = storage;
-			this.Path = storage.Path;
-			this.Name = storage.Name;
-			this.Id = string.Empty;
+			Path = storage.Path;
+			Name = storage.Name;
+			Id = string.Empty;
 		}
 
 		/// <inheritdoc/>

src/Files.App/App.xaml.cs

@@ -89,7 +89,7 @@ public App()
 			UnhandledException += OnUnhandledException;
 			TaskScheduler.UnobservedTaskException += OnUnobservedException;
 			InitializeComponent();
-			this.Services = ConfigureServices();
+			Services = ConfigureServices();
 			Ioc.Default.ConfigureServices(Services);
 		}
 

src/Files.App/BaseLayout.cs

@@ -371,7 +371,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs eventArgs)
 		{
 			base.OnNavigatedTo(eventArgs);
 			// Add item jumping handler
-			this.CharacterReceived += Page_CharacterReceived;
+			CharacterReceived += Page_CharacterReceived;
 			navigationArguments = (NavigationArguments)eventArgs.Parameter;
 			ParentShellPageInstance = navigationArguments.AssociatedTabInstance;
 			InitializeCommandsViewModel();
@@ -491,7 +491,7 @@ protected override void OnNavigatingFrom(NavigatingCancelEventArgs e)
 		{
 			base.OnNavigatingFrom(e);
 			// Remove item jumping handler
-			this.CharacterReceived -= Page_CharacterReceived;
+			CharacterReceived -= Page_CharacterReceived;
 			FolderSettings!.LayoutModeChangeRequested -= BaseFolderSettings_LayoutModeChangeRequested;
 			FolderSettings.GroupOptionPreferenceUpdated -= FolderSettings_GroupOptionPreferenceUpdated;
 			ItemContextMenuFlyout.Opening -= ItemContextFlyout_Opening;
@@ -578,7 +578,7 @@ private async Task LoadMenuItemsAsync()
 				itc.MaxHeight = Constants.UI.ContextMenuMaxHeight; // Reset menu max height
 			shellContextMenuItemCancellationToken?.Cancel();
 			shellContextMenuItemCancellationToken = new CancellationTokenSource();
-			SelectedItemsPropertiesViewModel.CheckAllFileExtensions(this.SelectedItems!.Select(selectedItem => selectedItem?.FileExtension).ToList()!);
+			SelectedItemsPropertiesViewModel.CheckAllFileExtensions(SelectedItems!.Select(selectedItem => selectedItem?.FileExtension).ToList()!);
 			var shiftPressed = Microsoft.UI.Input.InputKeyboardSource.GetKeyStateForCurrentThread(VirtualKey.Shift).HasFlag(Windows.UI.Core.CoreVirtualKeyStates.Down);
 			var items = ContextFlyoutItemHelper.GetItemContextCommandsWithoutShellItems(currentInstanceViewModel: InstanceViewModel!, workingDir: ParentShellPageInstance!.FilesystemViewModel.WorkingDirectory, selectedItems: SelectedItems!, selectedItemsPropertiesViewModel: SelectedItemsPropertiesViewModel, commandsViewModel: CommandsViewModel!, shiftPressed: shiftPressed, showOpenMenu: false);
 			ItemContextMenuFlyout.PrimaryCommands.Clear();

src/Files.App/DataModels/SuggestionModel.cs

@@ -60,17 +60,17 @@ private void Img_ImageOpened(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
 
 		public SuggestionModel(ListedItem item)
 		{
-			this.LoadFileIcon = item.LoadFileIcon;
-			this.NeedsPlaceholderGlyph = item.NeedsPlaceholderGlyph;
-			this.ItemPath = item.ItemPath;
-			this.Name = item.Name;
-			this.FileImage = item.FileImage;
+			LoadFileIcon = item.LoadFileIcon;
+			NeedsPlaceholderGlyph = item.NeedsPlaceholderGlyph;
+			ItemPath = item.ItemPath;
+			Name = item.Name;
+			FileImage = item.FileImage;
 		}
 
 		public SuggestionModel(string itemName, bool isRecentSearch)
 		{
-			this.IsRecentSearch = isRecentSearch;
-			this.Name = itemName;
+			IsRecentSearch = isRecentSearch;
+			Name = itemName;
 		}
 	}
 }

src/Files.App/Dialogs/AddItemDialog.xaml.cs

@@ -29,7 +29,7 @@ public AddItemDialog()
 		private void ListView_ItemClick(object sender, ItemClickEventArgs e)
 		{
 			ViewModel.ResultType = (e.ClickedItem as AddItemDialogListItemViewModel).ItemResult;
-			this.Hide();
+			Hide();
 		}
 
 		private async void AddItemDialog_Loaded(object sender, RoutedEventArgs e)

src/Files.App/Dialogs/CreateShortcutDialog.xaml.cs

@@ -18,7 +18,7 @@ public CreateShortcutDialogViewModel ViewModel
 
 		public CreateShortcutDialog()
 		{
-			this.InitializeComponent();
+			InitializeComponent();
 		}	
 
 		public new async Task<DialogResult> ShowAsync() => (DialogResult)await base.ShowAsync();

src/Files.App/Dialogs/CredentialDialog.xaml.cs

@@ -20,7 +20,7 @@ public CredentialDialogViewModel ViewModel
 
 		public CredentialDialog()
 		{
-			this.InitializeComponent();
+			InitializeComponent();
 		}
 
 		public new async Task<DialogResult> ShowAsync() => (DialogResult)await base.ShowAsync();

src/Files.App/Dialogs/DecompressArchiveDialog.xaml.cs

@@ -17,7 +17,7 @@ public DecompressArchiveDialogViewModel ViewModel
 
 		public DecompressArchiveDialog()
 		{
-			this.InitializeComponent();
+			InitializeComponent();
 		}
 
 		private void ContentDialog_PrimaryButtonClick(ContentDialog sender, ContentDialogButtonClickEventArgs args)

src/Files.App/Dialogs/DynamicDialog.xaml.cs

@@ -35,10 +35,10 @@ private ContentDialog SetContentDialogRoot(ContentDialog contentDialog)
 
 		public DynamicDialog(DynamicDialogViewModel dynamicDialogViewModel)
 		{
-			this.InitializeComponent();
+			InitializeComponent();
 
-			dynamicDialogViewModel.HideDialog = this.Hide;
-			this.ViewModel = dynamicDialogViewModel;
+			dynamicDialogViewModel.HideDialog = Hide;
+			ViewModel = dynamicDialogViewModel;
 		}
 
 		#region IDisposable

src/Files.App/Dialogs/ElevateConfirmDialog.xaml.cs

@@ -18,7 +18,7 @@ public ElevateConfirmDialogViewModel ViewModel
 
 		public ElevateConfirmDialog()
 		{
-			this.InitializeComponent();
+			InitializeComponent();
 		}
 
 		public new async Task<DialogResult> ShowAsync() => (DialogResult)await base.ShowAsync();