Fix: Fixed issue where details pane would sometimes fail to load (#12514)

Author: yaira2

src/Files.App/UserControls/Pane/PreviewPane.xaml

@@ -147,7 +147,10 @@
 				IsChecked="{x:Bind PaneSettingsService.ShowPreviewOnly, Mode=TwoWay, Converter={StaticResource BoolNegationConverter}}"
 				Style="{StaticResource Local.RadioButtonStyle}" />
 			<!--  Preview  -->
-			<RadioButton Content="{helpers:ResourceString Name=Preview}" Style="{StaticResource Local.RadioButtonStyle}" />
+			<RadioButton
+				Content="{helpers:ResourceString Name=Preview}"
+				IsChecked="{x:Bind PaneSettingsService.ShowPreviewOnly, Mode=TwoWay}"
+				Style="{StaticResource Local.RadioButtonStyle}" />
 		</StackPanel>
 
 		<Grid

src/Files.App/ViewModels/UserControls/PreviewPaneViewModel.cs

@@ -73,7 +73,7 @@ public PreviewPaneViewModel(IUserSettingsService userSettings, IPreviewPaneSetti
 			userSettingsService = userSettings;
 			previewSettingsService = previewSettings;
 
-			ShowPreviewOnlyInvoked = new RelayCommand(() => UpdateSelectedItemPreview());
+			ShowPreviewOnlyInvoked = new RelayCommand(async () => await UpdateSelectedItemPreview());
 
 			IsEnabled = previewSettingsService.IsEnabled;
 
@@ -286,12 +286,12 @@ public async Task UpdateSelectedItemPreview(bool downloadItem = false)
 
 		public ICommand ShowPreviewOnlyInvoked { get; }
 
-		private void UserSettingsService_OnSettingChangedEvent(object sender, SettingChangedEventArgs e)
+		private async void UserSettingsService_OnSettingChangedEvent(object sender, SettingChangedEventArgs e)
 		{
 			if (e.SettingName is nameof(IPreviewPaneSettingsService.ShowPreviewOnly))
 			{
 				// The preview will need refreshing as the file details won't be accurate
-				needsRefresh = true;
+				await UpdateSelectedItemPreview();
 			}
 		}
 
@@ -324,22 +324,6 @@ private async Task LoadBasicPreviewAsync()
 			}
 		}
 
-		/// <summary>
-		/// true if the content needs to be refreshed the next time the model is used
-		/// </summary>
-		private bool needsRefresh = false;
-
-		/// <summary>
-		/// refreshes the content if it needs to be refreshed, does nothing otherwise
-		/// </summary>
-		public void TryRefresh()
-		{
-			if (needsRefresh)
-			{
-				UpdateSelectedItemPreview();
-			}
-		}
-
 		public void Dispose()
 		{
 			userSettingsService.OnSettingChangedEvent -= UserSettingsService_OnSettingChangedEvent;