Fix: Handle edge case where OpenSubKey results in SecurityException (#16075)

Author: yaira2

src/Files.App/Helpers/Application/AppLifecycleHelper.cs

@@ -13,6 +13,7 @@
 using Sentry;
 using Sentry.Protocol;
 using System.IO;
+using System.Security;
 using System.Text;
 using Windows.ApplicationModel;
 using Windows.Storage;
@@ -348,15 +349,23 @@ public static void HandleAppUnhandledException(Exception? ex, bool showToastNoti
 		/// </summary>
 		public static bool IsAutoHideTaskbarEnabled()
 		{
-			const string registryKey = @"Software\Microsoft\Windows\CurrentVersion\Explorer\StuckRects3";
-			const string valueName = "Settings";
+			try
+			{
+				const string registryKey = @"Software\Microsoft\Windows\CurrentVersion\Explorer\StuckRects3";
+				const string valueName = "Settings";
 
-			using var key = Microsoft.Win32.Registry.CurrentUser.OpenSubKey(registryKey);
+				using var key = Microsoft.Win32.Registry.CurrentUser.OpenSubKey(registryKey);
 
-			var value = key?.GetValue(valueName) as byte[];
+				var value = key?.GetValue(valueName) as byte[];
 
-			// The least significant bit of the 9th byte controls the auto-hide setting																		
-			return value != null && ((value[8] & 0x01) == 1);
+				// The least significant bit of the 9th byte controls the auto-hide setting																		
+				return value != null && ((value[8] & 0x01) == 1);
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
 		}
 
 		/// <summary>

src/Files.App/Helpers/Environment/SoftwareHelpers.cs

@@ -2,55 +2,79 @@
 // Licensed under the MIT License. See the LICENSE.
 
 using Microsoft.Win32;
-using System.IO;
+using System.Security;
 
 namespace Files.App.Helpers
 {
 	internal static class SoftwareHelpers
 	{
 		private const string UninstallRegistryKey = @"Software\Microsoft\Windows\CurrentVersion\Uninstall";
 		private const string VsRegistryKey = @"SOFTWARE\Microsoft\VisualStudio";
-		
+
 		private const string VsCodeName = "Microsoft Visual Studio Code";
 
 
 		public static bool IsVSCodeInstalled()
 		{
-			return
-				ContainsName(Registry.CurrentUser.OpenSubKey(UninstallRegistryKey), VsCodeName) ||
-				ContainsName(Registry.LocalMachine.OpenSubKey(UninstallRegistryKey), VsCodeName);
+			try
+			{
+				return
+					ContainsName(Registry.CurrentUser.OpenSubKey(UninstallRegistryKey), VsCodeName) ||
+					ContainsName(Registry.LocalMachine.OpenSubKey(UninstallRegistryKey), VsCodeName);
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
 		}
 
 		public static bool IsVSInstalled()
 		{
-			var key = Registry.LocalMachine.OpenSubKey(VsRegistryKey);
-			if (key is null)
-				return false;
+			try
+			{
+				var key = Registry.LocalMachine.OpenSubKey(VsRegistryKey);
+				if (key is null)
+					return false;
 
-			key.Close();
+				key.Close();
 
-			return true;
+				return true;
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
 		}
 
 		private static bool ContainsName(RegistryKey? key, string find)
 		{
 			if (key is null)
 				return false;
 
-			foreach (var subKey in key.GetSubKeyNames().Select(key.OpenSubKey))
+			try
 			{
-				var displayName = subKey?.GetValue("DisplayName") as string;
-				if (!string.IsNullOrWhiteSpace(displayName) && displayName.StartsWith(find))
+				foreach (var subKey in key.GetSubKeyNames().Select(key.OpenSubKey))
 				{
-					key.Close();
+					var displayName = subKey?.GetValue("DisplayName") as string;
+					if (!string.IsNullOrWhiteSpace(displayName) && displayName.StartsWith(find))
+					{
+						key.Close();
 
-					return true;
+						return true;
+					}
 				}
-			}
 
-			key.Close();
+				key.Close();
 
-			return false;
+				return false;
+			}
+			catch (SecurityException)
+			{
+				// Handle edge case where OpenSubKey results in SecurityException
+				return false;
+			}
 		}
 	}
 }

src/Files.App/Utils/FileTags/FileTagsDatabase.cs

@@ -3,10 +3,11 @@
 
 using Microsoft.Win32;
 using System.Runtime.CompilerServices;
+using System.Security;
 using Windows.ApplicationModel;
-using JsonSerializer = System.Text.Json.JsonSerializer;
 using static Files.App.Helpers.RegistryHelpers;
 using static Files.App.Utils.FileTags.TaggedFileRegistry;
+using JsonSerializer = System.Text.Json.JsonSerializer;
 
 namespace Files.App.Utils.FileTags
 {
@@ -158,7 +159,16 @@ public IEnumerable<TaggedFile> GetAll()
 			var list = new List<TaggedFile>();
 
 			if (FileTagsKey is not null)
-				IterateKeys(list, FileTagsKey, 0);
+			{
+				try
+				{
+					IterateKeys(list, FileTagsKey, 0);
+				}
+				catch (SecurityException)
+				{
+					// Handle edge case where IterateKeys results in SecurityException
+				}
+			}
 
 			return list;
 		}
@@ -169,7 +179,16 @@ public IEnumerable<TaggedFile> GetAllUnderPath(string folderPath)
 			var list = new List<TaggedFile>();
 
 			if (FileTagsKey is not null)
-				IterateKeys(list, CombineKeys(FileTagsKey, folderPath), 0);
+			{
+				try
+				{
+					IterateKeys(list, CombineKeys(FileTagsKey, folderPath), 0);
+				}
+				catch (SecurityException)
+				{
+					// Handle edge case where IterateKeys results in SecurityException
+				}
+			}
 
 			return list;
 		}
@@ -212,9 +231,7 @@ private void IterateKeys(List<TaggedFile> list, string path, int depth)
 		{
 			using var key = Registry.CurrentUser.OpenSubKey(path);
 			if (key is null)
-			{
 				return;
-			}
 
 			if (key.ValueCount > 0)
 			{
@@ -225,11 +242,9 @@ private void IterateKeys(List<TaggedFile> list, string path, int depth)
 
 			foreach (var subKey in key.GetSubKeyNames())
 			{
+				// Skip FRN key
 				if (depth == 0 && subKey == "FRN")
-				{
-					// Skip FRN key
 					continue;
-				}
 
 				IterateKeys(list, CombineKeys(path, subKey), depth + 1);
 			}