Feature: Added option to always switch to newly created tab (#16613)

Author: yaira2

src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs

@@ -47,7 +47,7 @@ public async Task ExecuteAsync(object? parameter = null)
 			await Task.WhenAll(filePaths.Select(path => NavigationHelpers.OpenPath(path, _pageContext.ShellPage!)));
 
 			foreach (var path in folderPaths) 
-				await NavigationHelpers.OpenPathInNewTab(path, false);
+				await NavigationHelpers.OpenPathInNewTab(path);
 		}
 
 		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromHomeAction.cs

@@ -23,7 +23,7 @@ public override async Task ExecuteAsync(object? parameter = null)
 			if (await DriveHelpers.CheckEmptyDrive(HomePageContext.RightClickedItem!.Path))
 				return;
 
-			await NavigationHelpers.OpenPathInNewTab(HomePageContext.RightClickedItem!.Path ?? string.Empty, false);
+			await NavigationHelpers.OpenPathInNewTab(HomePageContext.RightClickedItem!.Path ?? string.Empty);
 		}
 
 		protected override void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabFromSidebarAction.cs

@@ -21,7 +21,7 @@ public override async Task ExecuteAsync(object? parameter = null)
 			if (await DriveHelpers.CheckEmptyDrive(SidebarContext.RightClickedItem!.Path))
 				return;
 
-			await NavigationHelpers.OpenPathInNewTab(SidebarContext.RightClickedItem!.Path ?? string.Empty, false);
+			await NavigationHelpers.OpenPathInNewTab(SidebarContext.RightClickedItem!.Path ?? string.Empty);
 		}
 
 		protected override void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Data/Contracts/IGeneralSettingsService.cs

@@ -60,6 +60,11 @@ public interface IGeneralSettingsService : IBaseSettingsService, INotifyProperty
 		/// </summary>
 		bool AlwaysOpenDualPaneInNewTab { get; set; }
 
+		/// <summary>
+		/// Gets or sets a value indicating whether or not to always switch to newly opened tab.
+		/// </summary>
+		bool AlwaysSwitchToNewlyOpenedTab { get; set; }
+
 		/// <summary>
 		/// Gets or sets a value indicating whether or not to display the quick access widget.
 		/// </summary>
@@ -114,7 +119,7 @@ public interface IGeneralSettingsService : IBaseSettingsService, INotifyProperty
 		/// Gets or sets a value indicating if the favorites section should be visible.
 		/// </summary>
 		bool ShowPinnedSection { get; set; }
-		
+
 		/// <summary>
 		/// Gets or sets a value indicating if the favorites section should be expanded.
 		/// </summary>
@@ -244,7 +249,7 @@ public interface IGeneralSettingsService : IBaseSettingsService, INotifyProperty
 		/// Gets or sets a value indicating whether or not to leave app running in the background.
 		/// </summary>
 		bool LeaveAppRunning { get; set; }
-		
+
 		/// <summary>
 		/// Gets or sets a value indicating whether or not to show Files in the system tray.
 		/// </summary>

src/Files.App/Helpers/Navigation/NavigationHelpers.cs

@@ -5,32 +5,50 @@
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Media;
 using Microsoft.UI.Xaml.Media.Imaging;
-using Windows.Storage.Search;
-using Microsoft.UI.Xaml.Media;
+using System.IO;
 using Windows.Storage;
+using Windows.Storage.Search;
 using Windows.System;
-using System.IO;
 
 namespace Files.App.Helpers
 {
 	public static class NavigationHelpers
 	{
+		private static readonly IGeneralSettingsService GeneralSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();
+
 		private static readonly IWindowsRecentItemsService WindowsRecentItemsService = Ioc.Default.GetRequiredService<IWindowsRecentItemsService>();
 		private static MainPageViewModel MainPageViewModel { get; } = Ioc.Default.GetRequiredService<MainPageViewModel>();
 		private static DrivesViewModel DrivesViewModel { get; } = Ioc.Default.GetRequiredService<DrivesViewModel>();
 		private static INetworkService NetworkService { get; } = Ioc.Default.GetRequiredService<INetworkService>();
 
-		public static Task OpenPathInNewTab(string? path, bool focusNewTab)
+		/// <summary>
+		/// Opens the path in a new tab.
+		/// </summary>
+		/// <param name="path">The path to open in a new tab.</param>
+		/// <param name="switchToNewTab">Indicates whether to switch to the new tab.</param>
+		/// <returns></returns>
+		public static Task OpenPathInNewTab(string? path, bool switchToNewTab)
+		{
+			return AddNewTabByPathAsync(typeof(ShellPanesPage), path, switchToNewTab);
+		}
+
+		/// <summary>
+		/// Opens the path in a new tab and automatically switches to the newly
+		/// created tab if configured in settings.
+		/// </summary>
+		/// <param name="path">The path to open in a new tab.</param>
+		/// <returns></returns>
+		public static Task OpenPathInNewTab(string? path)
 		{
-			return AddNewTabByPathAsync(typeof(ShellPanesPage), path, focusNewTab);
+			return AddNewTabByPathAsync(typeof(ShellPanesPage), path, GeneralSettingsService.AlwaysSwitchToNewlyOpenedTab);
 		}
 
 		public static Task AddNewTabAsync()
 		{
 			return AddNewTabByPathAsync(typeof(ShellPanesPage), "Home", true);
 		}
 
-		public static async Task AddNewTabByPathAsync(Type type, string? path, bool focusNewTab, int atIndex = -1)
+		public static async Task AddNewTabByPathAsync(Type type, string? path, bool switchToNewTab, int atIndex = -1)
 		{
 			if (string.IsNullOrEmpty(path))
 			{
@@ -63,7 +81,7 @@ public static async Task AddNewTabByPathAsync(Type type, string? path, bool focu
 
 			MainPageViewModel.AppInstances.Insert(index, tabItem);
 
-			if (focusNewTab)
+			if (switchToNewTab)
 				App.AppModel.TabStripSelectedIndex = index;
 		}
 

src/Files.App/Services/Settings/GeneralSettingsService.cs

@@ -77,6 +77,12 @@ public bool AlwaysOpenDualPaneInNewTab
 			set => Set(value);
 		}
 
+		public bool AlwaysSwitchToNewlyOpenedTab
+		{
+			get => Get(false);
+			set => Set(value);
+		}
+
 		public bool ShowQuickAccessWidget
 		{
 			get => Get(true);

src/Files.App/Strings/en-US/Resources.resw

@@ -4016,4 +4016,7 @@
   <data name="Total" xml:space="preserve">
     <value>Total</value>
   </data>
+  <data name="AlwaysSwitchToNewlyOpenedTab" xml:space="preserve">
+    <value>Always switch focus to newly created tab</value>
+  </data>
 </root>

src/Files.App/UserControls/Widgets/DrivesWidget.xaml.cs

@@ -38,7 +38,7 @@ sender is not Button button ||
 			if (await DriveHelpers.CheckEmptyDrive(path))
 				return;
 
-			await NavigationHelpers.OpenPathInNewTab(path, false);
+			await NavigationHelpers.OpenPathInNewTab(path);
 		}
 
 		private void Button_RightTapped(object sender, RightTappedRoutedEventArgs e)

src/Files.App/UserControls/Widgets/NetworkLocationsWidget.xaml.cs

@@ -38,7 +38,7 @@ sender is not Button button ||
 			if (await DriveHelpers.CheckEmptyDrive(path))
 				return;
 
-			await NavigationHelpers.OpenPathInNewTab(path, false);
+			await NavigationHelpers.OpenPathInNewTab(path);
 		}
 
 		private void Button_RightTapped(object sender, RightTappedRoutedEventArgs e)

src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs

@@ -26,7 +26,7 @@ sender is not Button button ||
 				button.Tag.ToString() is not string path)
 				return;
 
-			await NavigationHelpers.OpenPathInNewTab(path, false);
+			await NavigationHelpers.OpenPathInNewTab(path);
 		}
 
 		private async void Button_Click(object sender, RoutedEventArgs e)