Fix: Fixed exception that would sometimes occur when sharing items (#14298)

Author: yaira2

src/Files.App/Actions/Content/Share/ShareItemAction.cs

@@ -33,9 +33,7 @@ public ShareItemAction()
 
 		public Task ExecuteAsync()
 		{
-			ShareItemHelpers.ShareItems(context.SelectedItems);
-
-			return Task.CompletedTask;
+			return ShareItemHelpers.ShareItemsAsync(context.SelectedItems);
 		}
 
 		private bool IsContextPageTypeAdaptedToCommand()

src/Files.App/Helpers/ShareItemHelpers.cs

@@ -3,11 +3,13 @@
 
 using Files.App.Extensions;
 using Files.App.Utils;
+using Microsoft.UI.Xaml.Controls;
 using System;
 using System.Collections.Generic;
 using System.Linq;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Foundation;
+using Windows.Foundation.Metadata;
 using Windows.Storage;
 
 namespace Files.App.Helpers
@@ -19,15 +21,32 @@ public static bool IsItemShareable(ListedItem item)
 				(!item.IsShortcut || item.IsLinkItem) &&
 				(item.PrimaryItemAttribute != StorageItemTypes.Folder || item.IsArchive);
 
-		public static void ShareItems(IEnumerable<ListedItem> itemsToShare)
+		public static async Task ShareItemsAsync(IEnumerable<ListedItem> itemsToShare)
 		{
 			var interop = DataTransferManager.As<IDataTransferManagerInterop>();
 			IntPtr result = interop.GetForWindow(MainWindow.Instance.WindowHandle, InteropHelpers.DataTransferManagerInteropIID);
 
 			var manager = WinRT.MarshalInterface<DataTransferManager>.FromAbi(result);
 			manager.DataRequested += new TypedEventHandler<DataTransferManager, DataRequestedEventArgs>(Manager_DataRequested);
 
-			interop.ShowShareUIForWindow(MainWindow.Instance.WindowHandle);
+			try
+			{
+				interop.ShowShareUIForWindow(MainWindow.Instance.WindowHandle);
+			}
+			catch (Exception ex)
+			{
+				var errorDialog = new ContentDialog()
+				{
+					Title = "FaildToShareItems".GetLocalizedResource(),
+					Content = ex.Message,
+					PrimaryButtonText = "OK".GetLocalizedResource(),
+				};
+
+				if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
+					errorDialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;
+
+				await errorDialog.TryShowAsync();
+			}
 
 			async void Manager_DataRequested(DataTransferManager sender, DataRequestedEventArgs args)
 			{

src/Files.App/Strings/en-US/Resources.resw

@@ -3662,4 +3662,7 @@
   <data name="FailedToRotateImage" xml:space="preserve">
     <value>Failed to rotate the image</value>
   </data>
+  <data name="FaildToShareItems" xml:space="preserve">
+    <value>Failed to share items</value>
+  </data>
 </root>