Feature: Removed setting for displaying the home button

Author: yaira2

src/Files.App/Data/Contracts/IAppearanceSettingsService.cs

@@ -107,11 +107,6 @@ public interface IAppearanceSettingsService : IBaseSettingsService, INotifyPrope
 		/// </summary>
 		bool ShowTabActions { get; set; }
 
-		/// <summary>
-		/// Gets or sets a value whether the home button should be displayed.
-		/// </summary>
-		bool ShowHomeButton { get; set; }
-
 		/// <summary>
 		/// Gets or sets a value whether the shelf pane toggle button should be displayed.
 		/// </summary>

src/Files.App/Services/Settings/AppearanceSettingsService.cs

@@ -145,13 +145,6 @@ public bool ShowTabActions
 			set => Set(value);
 		}
 
-		/// <inheritdoc/>
-		public bool ShowHomeButton
-		{
-			get => Get(false);
-			set => Set(value);
-		}
-
 		/// <inheritdoc/>
 		public bool ShowShelfPaneToggleButton
 		{

src/Files.App/Strings/en-US/Resources.resw

@@ -4078,9 +4078,6 @@
   <data name="NavigateHomeDescription" xml:space="preserve">
     <value>Navigate to the home page</value>
   </data>
-  <data name="ShowHomeButton" xml:space="preserve">
-    <value>Show home button in address bar</value>
-  </data>
   <data name="Toolbars" xml:space="preserve">
     <value>Toolbars</value>
   </data>

src/Files.App/UserControls/NavigationToolbar.xaml

@@ -215,18 +215,6 @@
 				ToolTipService.ToolTip="{x:Bind Commands.RefreshItems.LabelWithHotKey, Mode=OneWay}">
 				<FontIcon FontSize="14" Glyph="{x:Bind Commands.RefreshItems.Glyph.BaseGlyph, Mode=OneTime}" />
 			</Button>
-
-			<Button
-				x:Name="HomeButton"
-				x:Load="{x:Bind ViewModel.ShowHomeButton, Mode=OneWay}"
-				AccessKey="H"
-				AccessKeyInvoked="Button_AccessKeyInvoked"
-				AutomationProperties.Name="{x:Bind Commands.NavigateHome.Label, Mode=OneWay}"
-				Command="{x:Bind Commands.NavigateHome, Mode=OneWay}"
-				Style="{StaticResource AddressToolbarButtonStyle}"
-				ToolTipService.ToolTip="{x:Bind Commands.NavigateHome.LabelWithHotKey, Mode=OneWay}">
-				<FontIcon FontSize="14" Glyph="{x:Bind Commands.NavigateHome.Glyph.BaseGlyph, Mode=OneTime}" />
-			</Button>
 		</StackPanel>
 
 		<!--  Legacy breadcrumb bar  -->

src/Files.App/UserControls/NavigationToolbar.xaml.cs

@@ -253,7 +253,7 @@ private void ClickablePath_GettingFocus(UIElement sender, GettingFocusEventArgs
 				return;
 
 			var previousControl = args.OldFocusedElement as FrameworkElement;
-			if (previousControl?.Name == nameof(HomeButton) || previousControl?.Name == nameof(Refresh))
+			if (previousControl?.Name == nameof(Refresh))
 				ViewModel.IsEditModeEnabled = true;
 		}
 

src/Files.App/ViewModels/Settings/AppearanceViewModel.cs

@@ -309,20 +309,6 @@ public bool ShowTabActions
 			}
 		}
 
-		public bool ShowHomeButton
-		{
-			get => UserSettingsService.AppearanceSettingsService.ShowHomeButton;
-			set
-			{
-				if (value != UserSettingsService.AppearanceSettingsService.ShowHomeButton)
-				{
-					UserSettingsService.AppearanceSettingsService.ShowHomeButton = value;
-
-					OnPropertyChanged();
-				}
-			}
-		}
-
 		public bool ShowShelfPaneToggleButton
 		{
 			get => UserSettingsService.AppearanceSettingsService.ShowShelfPaneToggleButton;

src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs

@@ -84,7 +84,6 @@ public sealed partial class NavigationToolbarViewModel : ObservableObject, IAddr
 
 		public bool SearchHasFocus { get; private set; }
 
-		public bool ShowHomeButton => AppearanceSettingsService.ShowHomeButton;
 		public bool EnableOmnibar => GeneralSettingsService.EnableOmnibar;
 		public bool ShowStatusCenterButton =>
 			AppearanceSettingsService.StatusCenterVisibility == StatusCenterVisibility.Always ||
@@ -349,9 +348,6 @@ public NavigationToolbarViewModel()
 			{
 				switch (e.PropertyName)
 				{
-					case nameof(AppearanceSettingsService.ShowHomeButton):
-						OnPropertyChanged(nameof(ShowHomeButton));
-						break;
 					case nameof(AppearanceSettingsService.StatusCenterVisibility):
 						OnPropertyChanged(nameof(ShowStatusCenterButton));
 						break;

src/Files.App/Views/Settings/AppearancePage.xaml

@@ -250,14 +250,6 @@
 				</wctcontrols:SettingsExpander.HeaderIcon>
 
 				<wctcontrols:SettingsExpander.Items>
-					<!--  Show home button  -->
-					<wctcontrols:SettingsCard Header="{helpers:ResourceString Name=ShowHomeButton}">
-						<ToggleSwitch
-							AutomationProperties.AutomationControlType="Custom"
-							AutomationProperties.Name="{helpers:ResourceString Name=ShowHomeButton}"
-							IsOn="{x:Bind ViewModel.ShowHomeButton, Mode=TwoWay}" />
-					</wctcontrols:SettingsCard>
-
 					<!--  Show shelf pane toggle button  -->
 					<wctcontrols:SettingsCard
 						x:Name="ShowShelfPaneSetting"