Code Quality: Improved Widget code (#14458)

Author: 0x5bfa

src/Files.App/Data/Contexts/HomePage/HomePageContext.cs

@@ -2,15 +2,14 @@
 // Licensed under the MIT License. See the LICENSE.
 
 using Files.App.UserControls.Widgets;
-using Files.App.ViewModels.Widgets;
 using Microsoft.UI.Xaml.Controls;
 using System.Collections.Immutable;
 
 namespace Files.App.Data.Contexts
 {
 	internal class HomePageContext : ObservableObject, IHomePageContext
 	{
-		private static readonly IImmutableList<FileTagsItemViewModel> emptyTaggedItems = Enumerable.Empty<FileTagsItemViewModel>().ToImmutableList();
+		private static readonly IImmutableList<WidgetFileTagCardItem> emptyTaggedItems = Enumerable.Empty<WidgetFileTagCardItem>().ToImmutableList();
 
 		public bool IsAnyItemRightClicked => rightClickedItem is not null;
 
@@ -20,20 +19,20 @@ internal class HomePageContext : ObservableObject, IHomePageContext
 		private CommandBarFlyout? itemContextFlyoutMenu = null;
 		public CommandBarFlyout? ItemContextFlyoutMenu => itemContextFlyoutMenu;
 
-		private IReadOnlyList<FileTagsItemViewModel> selectedTaggedItems = emptyTaggedItems;
-		public IReadOnlyList<FileTagsItemViewModel> SelectedTaggedItems
+		private IReadOnlyList<WidgetFileTagCardItem> selectedTaggedItems = emptyTaggedItems;
+		public IReadOnlyList<WidgetFileTagCardItem> SelectedTaggedItems
 		{
 			get => selectedTaggedItems;
 			set => selectedTaggedItems = value ?? emptyTaggedItems;
 		}
 
 		public HomePageContext()
 		{
-			HomePageWidget.RightClickedItemChanged += HomePageWidget_RightClickedItemChanged;
+			BaseWidgetViewModel.RightClickedItemChanged += HomePageWidget_RightClickedItemChanged;
 			FileTagsWidget.SelectedTaggedItemsChanged += FileTagsWidget_SelectedTaggedItemsChanged;
 		}
 
-		private void FileTagsWidget_SelectedTaggedItemsChanged(object? sender, IEnumerable<FileTagsItemViewModel> e)
+		private void FileTagsWidget_SelectedTaggedItemsChanged(object? sender, IEnumerable<WidgetFileTagCardItem> e)
 		{
 			SetProperty(ref selectedTaggedItems, e.ToList());
 		}

src/Files.App/Data/Contexts/HomePage/IHomePageContext.cs

@@ -1,8 +1,6 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.UserControls.Widgets;
-using Files.App.ViewModels.Widgets;
 using Microsoft.UI.Xaml.Controls;
 
 namespace Files.App.Data.Contexts
@@ -22,7 +20,7 @@ internal interface IHomePageContext
 		/// <summary>
 		/// An list containing all the selected tagged items
 		/// </summary>
-		IReadOnlyList<FileTagsItemViewModel> SelectedTaggedItems { get; }
+		IReadOnlyList<WidgetFileTagCardItem> SelectedTaggedItems { get; }
 
 		/// <summary>
 		/// Tells whether any item has been right clicked

src/Files.App/Data/Contexts/Tags/TagsContext.cs

@@ -1,12 +1,11 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.ViewModels.Widgets;
 using System.Collections.Immutable;
 
 namespace Files.App.Data.Contexts
 {
-    sealed class TagsContext : ITagsContext
+	sealed class TagsContext : ITagsContext
     {
 		private static readonly IReadOnlyList<(string path, bool isFolder)> _emptyTaggedItemsList
 			= Enumerable.Empty<(string path, bool isFolder)>().ToImmutableList();
@@ -29,7 +28,7 @@ sealed class TagsContext : ITagsContext
 
 		public TagsContext()
 		{
-			FileTagsContainerViewModel.SelectedTagChanged += SelectedTagsChanged;
+			WidgetFileTagsContainerItem.SelectedTagChanged += SelectedTagsChanged;
 			SidebarViewModel.SelectedTagChanged += SelectedTagsChanged;
 		}
 

src/Files.App/Data/Items/INavigationControlItem.cs renamed to src/Files.App/Data/Contracts/INavigationControlItem.cs

@@ -2,11 +2,9 @@
 // Licensed under the MIT License. See the LICENSE.
 
 using Files.App.UserControls.Sidebar;
-using Microsoft.UI.Xaml.Controls;
 
-namespace Files.App.Data.Items
+namespace Files.App.Data.Contracts
 {
-
 	public interface INavigationControlItem : IComparable<INavigationControlItem>, INotifyPropertyChanged, ISidebarItemModel
 	{
 		public new string Text { get; }

src/Files.App/UserControls/Widgets/IWidgetCardItem.cs renamed to src/Files.App/Data/Contracts/IWidgetCardItem.cs

@@ -2,9 +2,8 @@
 // Licensed under the MIT License. See the LICENSE.
 
 using Microsoft.UI.Xaml.Media.Imaging;
-using System.Threading.Tasks;
 
-namespace Files.App.UserControls.Widgets
+namespace Files.App.Data.Contracts
 {
 	public interface IWidgetCardItem<T>
 	{
@@ -14,4 +13,4 @@ public interface IWidgetCardItem<T>
 
 		Task LoadCardThumbnailAsync();
 	}
-}
+}

src/Files.App/ViewModels/Widgets/IWidgetItem.cs renamed to src/Files.App/Data/Contracts/IWidgetViewModel.cs

@@ -3,9 +3,9 @@
 
 using Microsoft.UI.Xaml.Controls;
 
-namespace Files.App.ViewModels.Widgets
+namespace Files.App.Data.Contracts
 {
-	public interface IWidgetItem : IDisposable
+	public interface IWidgetViewModel : IDisposable
 	{
 		string WidgetName { get; }
 

src/Files.App/Data/EventArguments/QuickAccessCardEventArgs.cs

@@ -0,0 +1,38 @@
+// Copyright (c) 2023 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Data.EventArguments
+{
+	public class QuickAccessCardEventArgs : EventArgs
+	{
+		public LocationItem? Item { get; set; }
+	}
+
+	public class QuickAccessCardInvokedEventArgs : EventArgs
+	{
+		public string? Path { get; set; }
+	}
+
+	public class ModifyQuickAccessEventArgs : EventArgs
+	{
+		public string[]? Paths { get; set; }
+		public ShellFileItem[]? Items { get; set; }
+		public bool Add;
+		public bool Pin = true;
+		public bool Reset = false;
+		public bool Reorder = false;
+
+		public ModifyQuickAccessEventArgs(string[] paths, bool add)
+		{
+			Paths = paths;
+			Add = add;
+		}
+
+		public ModifyQuickAccessEventArgs(ShellFileItem[] items, bool add)
+		{
+			Paths = items.Select(x => x.FilePath).ToArray();
+			Items = items;
+			Add = add;
+		}
+	}
+}

src/Files.App/Data/EventArguments/WidgetsRightClickedItemChangedEventArgs.cs

@@ -1,7 +1,6 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.UserControls.Widgets;
 using Microsoft.UI.Xaml.Controls;
 
 namespace Files.App.Data.EventArguments

src/Files.App/Data/Items/LocationItem.cs

@@ -155,4 +155,4 @@ public RecycleBinLocationItem()
 			RecycleBinManager.Default.RecycleBinItemDeleted += RefreshSpaceUsed;
 		}
 	}
-}
+}

src/Files.App/Utils/Library/LibraryLocationItem.cs renamed to src/Files.App/Data/Items/SidebarLibraryItem.cs

@@ -1,7 +1,7 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-namespace Files.App.Utils.Library
+namespace Files.App.Data.Items
 {
 	public class LibraryLocationItem : LocationItem
 	{
@@ -57,4 +57,4 @@ public async Task LoadLibraryIconAsync()
 		public override bool Equals(object obj)
 			=> obj is LibraryLocationItem other && GetType() == obj.GetType() && string.Equals(Path, other.Path, System.StringComparison.OrdinalIgnoreCase);
 	}
-}
+}