Use IApplicationDestinations

Author: 0x5bfa

src/Files.App.CsWin32/NativeMethods.txt

@@ -143,3 +143,8 @@ SHCreateItemFromIDList
 BHID_SFUIObject
 IContextMenu
 CMF_NORMAL
+CMF_OPTIMIZEFORINVOKE
+IApplicationDestinations
+ApplicationDestinations
+IApplicationDocumentLists
+ApplicationDocumentLists

src/Files.App/Services/Windows/WindowsRecentItemsService.cs

@@ -101,10 +101,6 @@ public unsafe bool Add(string path)
 				fixed (char* cPath = path)
 					PInvoke.SHAddToRecentDocs((uint)SHARD.SHARD_PATHW, cPath);
 
-				// Update
-				_ = UpdateRecentFilesAsync();
-				_ = UpdateRecentFoldersAsync();
-
 				return true;
 			}
 			catch (Exception ex)
@@ -119,37 +115,19 @@ public unsafe bool Remove(RecentItem item)
 		{
 			try
 			{
-				/* 
-				// Initialize IFileOperation instance
-				using ComPtr<IFileOperation> pFileOperation = default;
-				var fileOperationIid = typeof(IFileOperation).GUID;
-				var fileOperationInstanceIid = typeof(FileOperation).GUID;
-				HRESULT hr = PInvoke.CoCreateInstance(&fileOperationInstanceIid, null, CLSCTX.CLSCTX_LOCAL_SERVER, &fileOperationIid, (void**)pFileOperation.GetAddressOf());
-				hr = pFileOperation.Get()->SetOperationFlags(FILEOPERATION_FLAGS.FOF_NO_UI);
-				hr = pFileOperation.Get()->SetOwnerWindow(new(MainWindow.Instance.WindowHandle));
-
-				// Perform deletion
-				hr = pFileOperation.Get()->DeleteItem(item.ShellItem.Get(), null);
-				hr = pFileOperation.Get()->PerformOperations();
-
-				// Update
-				_ = UpdateRecentFilesAsync();
-				_ = UpdateRecentFoldersAsync();
-				*/
-
 				/*
 				var bhid = PInvoke.BHID_SFUIObject;
 				var contextMenuIid = typeof(IContextMenu).GUID;
 				using ComPtr<IContextMenu> pContextMenu = default;
 				HRESULT hr = item.ShellItem.Get()->BindToHandler(null, &bhid, &contextMenuIid, (void**)pContextMenu.GetAddressOf());
 				HMENU hMenu = PInvoke.CreatePopupMenu();
-				hr = pContextMenu.Get()->QueryContextMenu(hMenu, 0, 1, 0x7FFF, PInvoke.CMF_NORMAL);
+				hr = pContextMenu.Get()->QueryContextMenu(hMenu, 0, 1, 0x7FFF, PInvoke.CMF_OPTIMIZEFORINVOKE);
 
 				// Initialize invocation info
 				CMINVOKECOMMANDINFO cmi = default;
 				cmi.cbSize = (uint)sizeof(CMINVOKECOMMANDINFO);
 				cmi.nShow = (int)SHOW_WINDOW_CMD.SW_HIDE;
-				fixed (byte* pVerb = Encoding.ASCII.GetBytes("delete"))
+				fixed (byte* pVerb = Encoding.ASCII.GetBytes("remove"))
 					cmi.lpVerb = new(pVerb);
 
 				// Invoke the verb
@@ -158,10 +136,29 @@ public unsafe bool Remove(RecentItem item)
 					throw new COMException("Failed to remove the recent item from Recent.", hr.Value);
 				*/
 
+				using ComPtr<IApplicationDestinations> pApplicationDestinations = default;
+				var applicationDestinationsIid = typeof(IApplicationDestinations).GUID;
+				var applicationDestinationsInstanceIid = typeof(ApplicationDestinations).GUID;
+
+				PInvoke.CoCreateInstance(
+					&applicationDestinationsInstanceIid,
+					null,
+					CLSCTX.CLSCTX_LOCAL_SERVER,
+					&applicationDestinationsIid,
+					(void**)pApplicationDestinations.GetAddressOf())
+				.ThrowOnFailure();
+
+				// Set App ID
+				fixed (char* pszAppId = "Microsoft.Windows.Explorer")
+					pApplicationDestinations.Get()->SetAppID(pszAppId);
+
+				pApplicationDestinations.Get()->RemoveDestination((IUnknown*)item.ShellItem.Get());
+
 				return true;
 			}
-			catch
+			catch (Exception ex)
 			{
+				App.Logger.LogWarning(ex, ex.Message);
 				return false;
 			}
 		}
@@ -171,11 +168,25 @@ public unsafe bool Clear()
 		{
 			try
 			{
-				PInvoke.SHAddToRecentDocs((uint)SHARD.SHARD_PIDL, null);
+				//PInvoke.SHAddToRecentDocs((uint)SHARD.SHARD_PIDL, null);
+
+				using ComPtr<IApplicationDestinations> pApplicationDestinations = default;
+				var applicationDestinationsIid = typeof(IApplicationDestinations).GUID;
+				var applicationDestinationsInstanceIid = typeof(ApplicationDestinations).GUID;
+
+				PInvoke.CoCreateInstance(
+					&applicationDestinationsInstanceIid,
+					null,
+					CLSCTX.CLSCTX_LOCAL_SERVER,
+					&applicationDestinationsIid,
+					(void**)pApplicationDestinations.GetAddressOf())
+				.ThrowOnFailure();
+
+				// Set App ID
+				fixed (char* pszAppId = "Microsoft.Windows.Explorer")
+					pApplicationDestinations.Get()->SetAppID(pszAppId);
 
-				// Update
-				_ = UpdateRecentFilesAsync();
-				_ = UpdateRecentFoldersAsync();
+				pApplicationDestinations.Get()->RemoveAllDestinations();
 
 				return true;
 			}
@@ -239,7 +250,7 @@ private unsafe bool UpdateRecentItems(bool isFolder)
 					// Get the PIDL
 					PInvoke.SHGetIDListFromObject((IUnknown*)pShellItem.Get(), out var pidl);
 
-					// Get the original path
+					// Get the date last modified
 					using ComPtr<IShellItem2> pShellItem2 = default;
 					var shellItem2Iid = typeof(IShellItem2).GUID;
 					hr = pShellItem.Get()->QueryInterface(&shellItem2Iid, (void**)pShellItem2.GetAddressOf());
@@ -262,7 +273,7 @@ private unsafe bool UpdateRecentItems(bool isFolder)
 				if (recentItems.Count is 0)
 					return false;
 
-				// Sort by last modified
+				// Sort by the display name
 				var orderedRecentItems = recentItems.OrderBy(x => x.Name).ToList();
 
 				var snapshot = isFolder ? RecentFolders : RecentFiles;