Add option to disable OpenTerminal action

Author: Lamparter

src/Files.App/Actions/Open/OpenTerminalAction.cs

@@ -10,6 +10,8 @@ internal partial class OpenTerminalAction : ObservableObject, IAction
 	{
 		private readonly IContentPageContext context;
 
+		private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>();
+
 		public virtual string Label
 			=> Strings.OpenTerminal.GetLocalizedResource();
 
@@ -96,6 +98,9 @@ protected virtual string[] GetPaths()
 
 		private bool GetIsExecutable()
 		{
+			if (UserSettingsService.GeneralSettingsService.ShowOpenTerminal is false)
+				return false;
+
 			if (context.PageType is ContentPageTypes.None or ContentPageTypes.Home or ContentPageTypes.RecycleBin or ContentPageTypes.ZipFolder or ContentPageTypes.ReleaseNotes or ContentPageTypes.Settings)
 				return false;
 

src/Files.App/Actions/Open/OpenTerminalFromHomeAction.cs

@@ -6,6 +6,7 @@ namespace Files.App.Actions
 	internal sealed partial class OpenTerminalFromHomeAction : OpenTerminalAction
 	{
 		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
+		private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>();
 
 		public override string Label
 			=> Strings.OpenTerminal.GetLocalizedResource();
@@ -14,6 +15,7 @@ public override string Description
 			=> Strings.OpenTerminalDescription.GetLocalizedResource();
 
 		public override bool IsExecutable =>
+			UserSettingsService.GeneralSettingsService.ShowOpenTerminal &&
 			HomePageContext.IsAnyItemRightClicked &&
 			HomePageContext.RightClickedItem is not null &&
 			(HomePageContext.RightClickedItem is WidgetFileTagCardItem fileTagItem

src/Files.App/Actions/Open/OpenTerminalFromSidebarAction.cs

@@ -6,6 +6,7 @@ namespace Files.App.Actions
 	internal sealed partial class OpenTerminalFromSidebarAction : OpenTerminalAction
 	{
 		private ISidebarContext SidebarContext { get; } = Ioc.Default.GetRequiredService<ISidebarContext>();
+		private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>();
 
 		public override string Label
 			=> Strings.OpenTerminal.GetLocalizedResource();
@@ -14,6 +15,7 @@ public override string Description
 			=> Strings.OpenTerminalDescription.GetLocalizedResource();
 
 		public override bool IsExecutable =>
+			UserSettingsService.GeneralSettingsService.ShowOpenTerminal &&
 			SidebarContext.IsItemRightClicked &&
 			SidebarContext.RightClickedItem is not null &&
 			SidebarContext.RightClickedItem.MenuOptions.ShowShellItems &&

src/Files.App/Data/Contracts/IGeneralSettingsService.cs

@@ -215,6 +215,11 @@ public interface IGeneralSettingsService : IBaseSettingsService, INotifyProperty
 		/// </summary>
 		bool ShowOpenInNewPane { get; set; }
 
+		/// <summary>
+		/// Gets or sets a value indicating whether or not to show the option to open folders in Windows Terminal.
+		/// </summary>
+		bool ShowOpenTerminal { get; set; }
+
 		/// <summary>
 		/// Gets or sets a value indicating whether or not to show the option to copy an items path.
 		/// </summary>

src/Files.App/Services/Settings/GeneralSettingsService.cs

@@ -281,6 +281,12 @@ public bool ShowOpenInNewPane
 			set => Set(value);
 		}
 
+		public bool ShowOpenTerminal
+		{
+			get => Get(true);
+			set => Set(value);
+		}
+
 		public bool ShowCopyPath
 		{
 			get => Get(true);

src/Files.App/Strings/en-US/Resources.resw

@@ -4273,4 +4273,7 @@
   <data name="Filename" xml:space="preserve">
     <value>Filename</value>
   </data>
+  <data name="ShowOpenTerminal" xml:space="preserve">
+    <value>Show option to open folders in Windows Terminal</value>
+  </data>
 </root>

src/Files.App/ViewModels/Settings/GeneralViewModel.cs

@@ -521,6 +521,19 @@ public bool ShowOpenInNewWindow
 			}
 		}
 
+		public bool ShowOpenTerminal
+		{
+			get => UserSettingsService.GeneralSettingsService.ShowOpenTerminal;
+			set
+			{
+				if (value != UserSettingsService.GeneralSettingsService.ShowOpenTerminal)
+				{
+					UserSettingsService.GeneralSettingsService.ShowOpenTerminal = value;
+					OnPropertyChanged();
+				}
+			}
+		}
+
 		private string selectedShellPaneArrangementType;
 		public string SelectedShellPaneArrangementType
 		{

src/Files.App/Views/Settings/GeneralPage.xaml

@@ -261,6 +261,11 @@
 						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowOpenInNewPane}" IsOn="{x:Bind ViewModel.ShowOpenInNewPane, Mode=TwoWay}" />
 					</wctcontrols:SettingsCard>
 
+					<!--  Open in Windows Terminal  -->
+					<wctcontrols:SettingsCard Header="{helpers:ResourceString Name=ShowOpenTerminal}">
+						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowOpenTerminal}" IsOn="{x:Bind ViewModel.ShowOpenTerminal, Mode=TwoWay}" />
+					</wctcontrols:SettingsCard>
+
 					<!--  Copy path  -->
 					<wctcontrols:SettingsCard Header="{helpers:ResourceString Name=ShowCopyPath}">
 						<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowCopyPath}" IsOn="{x:Bind ViewModel.ShowCopyPath, Mode=TwoWay}" />