Fixed an issue where the tab title was missing in the documents library (#8107)

Author: puppetsw

src/Files/Strings/en-US/Resources.resw

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -267,21 +267,9 @@
   <data name="Downloads" xml:space="preserve">
     <value>Downloads</value>
   </data>
-  <data name="SidebarHome" xml:space="preserve">
-    <value>Home</value>
-  </data>
-  <data name="SidebarMusic" xml:space="preserve">
-    <value>Music</value>
-  </data>
-  <data name="SidebarPictures" xml:space="preserve">
-    <value>Pictures</value>
-  </data>
   <data name="SideBarUnpinFromFavorites.Text" xml:space="preserve">
     <value>Unpin from Favorites</value>
   </data>
-  <data name="SidebarVideos" xml:space="preserve">
-    <value>Videos</value>
-  </data>
   <data name="BaseLayoutContextFlyoutSortBy.Text" xml:space="preserve">
     <value>Sort by</value>
   </data>
@@ -2744,6 +2732,15 @@ We use App Center to track which settings are being used, find bugs, and fix cra
   <data name="CloseOtherTabs" xml:space="preserve">
     <value>Close other tabs</value>
   </data>
+  <data name="Music" xml:space="preserve">
+    <value>Music</value>
+  </data>
+  <data name="Pictures" xml:space="preserve">
+    <value>Pictures</value>
+  </data>
+  <data name="Videos" xml:space="preserve">
+    <value>Videos</value>
+  </data>
   <data name="UpdateFiles" xml:space="preserve">
     <value>Update Files</value>
   </data>

src/Files/UserControls/Widgets/FolderWidget.xaml.cs

@@ -173,17 +173,17 @@ private async void FolderWidget_Loaded(object sender, RoutedEventArgs e)
             });
             ItemsAdded.Add(new LibraryCardItem
             {
-                Text = "SidebarMusic".GetLocalized(),
+                Text = "Music".GetLocalized(),
                 Path = UserDataPaths.GetDefault().Music,
             });
             ItemsAdded.Add(new LibraryCardItem
             {
-                Text = "SidebarPictures".GetLocalized(),
+                Text = "Pictures".GetLocalized(),
                 Path = UserDataPaths.GetDefault().Pictures,
             });
             ItemsAdded.Add(new LibraryCardItem
             {
-                Text = "SidebarVideos".GetLocalized(),
+                Text = "Videos".GetLocalized(),
                 Path = UserDataPaths.GetDefault().Videos,
             });
 

src/Files/ViewModels/MainPageViewModel.cs

@@ -288,29 +288,9 @@ public static async Task UpdateTabInfo(TabItem tabItem, object navigationArg)
             }
             else if (App.LibraryManager.TryGetLibrary(currentPath, out LibraryLocationItem library))
             {
-                var libName = System.IO.Path.GetFileNameWithoutExtension(library.Path);
-                switch (libName)
-                {
-                    case "Documents":
-                        tabLocationHeader = $"Sidebar{libName}".GetLocalized(); // Show localized name
-                        break;
-
-                    case "Pictures":
-                        tabLocationHeader = $"Sidebar{libName}".GetLocalized(); // Show localized name
-                        break;
-
-                    case "Music":
-                        tabLocationHeader = $"Sidebar{libName}".GetLocalized(); // Show localized name
-                        break;
-
-                    case "Videos":
-                        tabLocationHeader = $"Sidebar{libName}".GetLocalized(); // Show localized name
-                        break;
-
-                    default:
-                        tabLocationHeader = library.Text; // Show original name
-                        break;
-                }
+                var libName = System.IO.Path.GetFileNameWithoutExtension(library.Path).GetLocalized();
+                // If localized string is empty use the library name.
+                tabLocationHeader = string.IsNullOrEmpty(libName) ? library.Text : libName;
             }
             else
             {

src/Files/ViewModels/SettingsViewModels/PreferencesViewModel.cs

@@ -71,7 +71,7 @@ public PreferencesViewModel()
             PagesOnStartupList.CollectionChanged += PagesOnStartupList_CollectionChanged;
 
             var recentsItem = new MenuFlyoutSubItemViewModel("JumpListRecentGroupHeader".GetLocalized());
-            recentsItem.Items.Add(new MenuFlyoutItemViewModel("SidebarHome".GetLocalized(), "Home".GetLocalized(), AddPageCommand));
+            recentsItem.Items.Add(new MenuFlyoutItemViewModel("Home".GetLocalized(), "Home".GetLocalized(), AddPageCommand));
             PopulateRecentItems(recentsItem).ContinueWith(_ =>
             {
                 AddFlyoutItemsSource = new ReadOnlyCollection<IMenuFlyoutItem>(new IMenuFlyoutItem[] {
@@ -293,7 +293,7 @@ public string Text
                 {
                     if (Path == "Home".GetLocalized())
                     {
-                        return "SidebarHome".GetLocalized();
+                        return "Home".GetLocalized();
                     }
                     if (Path == CommonPaths.RecycleBinPath)
                     {