Introduced WindowsStorableHelpers.GetRegistryValue

Author: 0x5bfa

src/Files.App.CsWin32/NativeMethods.txt

@@ -225,6 +225,8 @@ QITIPF_FLAGS
 GetKeyboardState
 MapVirtualKey
 GetKeyboardLayout
-RegOpenKeyExW
 HKEY_CLASSES_ROOT
+HKEY_CURRENT_USER
+RegOpenKeyEx
 RegEnumKeyEx
+RegGetValue

src/Files.App.Storage/Storables/WindowsStorage/ShellNewManager.cs

@@ -10,10 +10,38 @@ namespace Files.App.Storage
 {
 	public static partial class ShellNewManager
 	{
+		public const string CachedShellNewItemsRegistryPath = "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Discardable\\PostSetup\\ShellNew";
+
 		public static IEnumerable<ShellNewItem> GetItems()
+		{
+			var cachedItems = GetItemsFromCache();
+			if (cachedItems.Any())
+			{
+				foreach (var item in cachedItems)
+					yield return item;
+
+				yield break;
+			}
+
+			foreach (var item in GetItemsFromAssoc())
+				yield return item;
+		}
+
+		private static IEnumerable<ShellNewItem> GetItemsFromCache()
+		{
+			bool fRes = WindowsStorableHelpers.GetRegistryValue(HKEY.HKEY_CURRENT_USER, CachedShellNewItemsRegistryPath, "Classes", REG_ROUTINE_FLAGS.RRF_RT_REG_MULTI_SZ, out string? cachedExtensions);
+			if (!fRes)
+			{
+				yield break;
+			}
+
+			// TODO: Access each cached extension and get the ShellNewItem properties
+		}
+
+		private static IEnumerable<ShellNewItem> GetItemsFromAssoc()
 		{
 			var newMenuItems = new List<ShellNewItem>();
-			string[] extensionsExcluded = [ ".contact", ".library-ms", ".url", ".lnk" ];
+			string[] extensionsExcluded = [".contact", ".library-ms", ".url", ".lnk"];
 
 			// Get a handle of HKEY_CLASSES_ROOT
 			bool fRes = WindowsStorableHelpers.OpenRegistryKey(HKEY.HKEY_CLASSES_ROOT, string.Empty, REG_SAM_FLAGS.KEY_READ, out HKEY hKey);
@@ -41,6 +69,7 @@ public static IEnumerable<ShellNewItem> GetItems()
 			// TODO: Add .txt if necessary
 
 			if (!hKey.IsNull) PInvoke.RegCloseKey(hKey);
+
 		}
 	}
 }

src/Files.App.Storage/Storables/WindowsStorage/WindowsStorableHelpers.Registry.cs

@@ -1,26 +1,19 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
+using System.Runtime.InteropServices;
 using Windows.Win32;
 using Windows.Win32.Foundation;
 using Windows.Win32.System.Registry;
 
-// There are two kinds of ShellNew entry residence:
-// 
-// 1.) .docx > Word.Document.12 > ShellNew
-// 2.) .mdb > SellNew
-
-
 namespace Files.App.Storage
 {
 	public unsafe static partial class WindowsStorableHelpers
 	{
 		public static bool OpenRegistryKey(HKEY hRootKey, string subKey, REG_SAM_FLAGS flags, out HKEY hKey)
 		{
-			hKey = default;
-
-			HKEY hResultKey = default;
 			WIN32_ERROR dwResult = default;
+			HKEY hResultKey = default;
 
 			fixed (char* pszSubKey = subKey)
 				dwResult = PInvoke.RegOpenKeyEx(hRootKey, pszSubKey, 0, flags, &hResultKey);
@@ -30,6 +23,50 @@ public static bool OpenRegistryKey(HKEY hRootKey, string subKey, REG_SAM_FLAGS f
 			return dwResult is WIN32_ERROR.ERROR_SUCCESS;
 		}
 
+		public static bool GetRegistryValue<T>(HKEY hRootKey, string subKey, string valueName, REG_ROUTINE_FLAGS flags, out T? valueData)
+		{
+			valueData = default;
+
+			WIN32_ERROR dwResult = default;
+			HKEY hKey = hRootKey;
+
+			if (!string.IsNullOrEmpty(subKey))
+			{
+				fixed (char* pszSubKey = subKey)
+					dwResult = PInvoke.RegOpenKeyEx(hRootKey, pszSubKey, 0, REG_SAM_FLAGS.KEY_QUERY_VALUE, &hKey);
+
+				if (dwResult is not WIN32_ERROR.ERROR_SUCCESS)
+				{
+					if (!hKey.IsNull) PInvoke.RegCloseKey(hKey);
+					return false;
+				}
+			}
+
+			byte* pData = null;
+			uint cbData = 0U;
+
+			fixed (char* pszValueName = valueName)
+			{
+				dwResult = PInvoke.RegGetValue(hKey, default, pszValueName, flags, null, null, &cbData);
+
+				if (dwResult is WIN32_ERROR.ERROR_SUCCESS or WIN32_ERROR.ERROR_MORE_DATA)
+				{
+					if (cbData is 0U)
+						return false;
+
+					pData = (byte*)NativeMemory.Alloc(cbData);
+					dwResult = PInvoke.RegGetValue(hKey, default, pszValueName, flags, null, pData, &cbData);
+
+					valueData = Marshal.PtrToStructure<T>((nint)pData);
+					NativeMemory.Free(pData);
+				}
+			}
+
+			if (!hKey.IsNull) PInvoke.RegCloseKey(hKey);
+
+			return dwResult is WIN32_ERROR.ERROR_SUCCESS;
+		}
+
 		public static string[] EnumerateRegistryKeyNames(HKEY hKey)
 		{
 			WIN32_ERROR dwResult = default;