Fix: Fixed ArgumentException when wrong color was specified (#14751)

Author: hishitetsu

src/Files.App/Helpers/UI/AppThemeResourcesHelper.cs

@@ -16,27 +16,62 @@ public static class AppThemeResourcesHelper
 		public static void LoadAppResources(this IResourcesService service, IAppearanceSettingsService appearance)
 		{
 			var useCompactStyles = appearance.UseCompactStyles;
-			var appThemeBackgroundColor = ColorHelper.ToColor(appearance.AppThemeBackgroundColor);
+			var appThemeBackgroundColor = appearance.AppThemeBackgroundColor;
 			var appThemeAddressBarBackgroundColor = appearance.AppThemeAddressBarBackgroundColor;
 			var appThemeSidebarBackgroundColor = appearance.AppThemeSidebarBackgroundColor;
 			var appThemeFileAreaBackgroundColor = appearance.AppThemeFileAreaBackgroundColor;
 			var appThemeFontFamily = appearance.AppThemeFontFamily;
 
 			service.SetCompactSpacing(useCompactStyles);
-			service.SetAppThemeBackgroundColor(appThemeBackgroundColor.FromWindowsColor());
+			try
+			{
+				service.SetAppThemeBackgroundColor(ColorHelper.ToColor(appThemeBackgroundColor).FromWindowsColor());
+			}
+			catch
+			{
+				appearance.AppThemeBackgroundColor = "#00000000"; //migrate to new default
+				service.SetAppThemeBackgroundColor(ColorHelper.ToColor("#00000000").FromWindowsColor());
+			}
 
 			if (!string.IsNullOrWhiteSpace(appThemeAddressBarBackgroundColor) && appThemeAddressBarBackgroundColor != "#00000000")
-				service.SetAppThemeAddressBarBackgroundColor(ColorHelper.ToColor(appThemeAddressBarBackgroundColor).FromWindowsColor());
+			{
+				try
+				{
+					service.SetAppThemeAddressBarBackgroundColor(ColorHelper.ToColor(appThemeAddressBarBackgroundColor).FromWindowsColor());
+				}
+				catch
+				{
+					appearance.AppThemeAddressBarBackgroundColor = ""; //migrate to new default
+				}
+			}
 			else
 				appearance.AppThemeAddressBarBackgroundColor = ""; //migrate to new default
 
-			if (!string.IsNullOrWhiteSpace(appThemeSidebarBackgroundColor) && appThemeAddressBarBackgroundColor != "#00000000")
-				service.SetAppThemeSidebarBackgroundColor(ColorHelper.ToColor(appThemeSidebarBackgroundColor).FromWindowsColor());
+			if (!string.IsNullOrWhiteSpace(appThemeSidebarBackgroundColor) && appThemeSidebarBackgroundColor != "#00000000")
+			{
+				try
+				{
+					service.SetAppThemeSidebarBackgroundColor(ColorHelper.ToColor(appThemeSidebarBackgroundColor).FromWindowsColor());
+				}
+				catch
+				{
+					appearance.AppThemeSidebarBackgroundColor = ""; //migrate to new default
+				}
+			}
 			else
 				appearance.AppThemeSidebarBackgroundColor = ""; //migrate to new default
 
-			if (!string.IsNullOrWhiteSpace(appThemeFileAreaBackgroundColor) && appThemeAddressBarBackgroundColor != "#00000000")
-				service.SetAppThemeFileAreaBackgroundColor(ColorHelper.ToColor(appThemeFileAreaBackgroundColor).FromWindowsColor());
+			if (!string.IsNullOrWhiteSpace(appThemeFileAreaBackgroundColor) && appThemeFileAreaBackgroundColor != "#00000000")
+			{
+				try
+				{
+					service.SetAppThemeFileAreaBackgroundColor(ColorHelper.ToColor(appThemeFileAreaBackgroundColor).FromWindowsColor());
+				}
+				catch
+				{
+					appearance.AppThemeFileAreaBackgroundColor = ""; //migrate to new default
+				}
+			}
 			else
 				appearance.AppThemeFileAreaBackgroundColor = ""; //migrate to new default
 

src/Files.App/ViewModels/Settings/AppearanceViewModel.cs

@@ -134,7 +134,14 @@ public string AppThemeBackgroundColor
 					UserSettingsService.AppearanceSettingsService.AppThemeBackgroundColor = value;
 
 					// Apply the updated background resource
-					ResourcesService.SetAppThemeBackgroundColor(ColorHelper.ToColor(value).FromWindowsColor());
+					try
+					{
+						ResourcesService.SetAppThemeBackgroundColor(ColorHelper.ToColor(value).FromWindowsColor());
+					}
+					catch
+					{
+						ResourcesService.SetAppThemeBackgroundColor(ColorHelper.ToColor("#00000000").FromWindowsColor());
+					}
 					ResourcesService.ApplyResources();
 
 					OnPropertyChanged();