Skip to content

Commit ebfdb25

Browse files
committed
Fix tabview over-expansion bug
1 parent ab1ba8b commit ebfdb25

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

Files UWP/InstanceTabsView.xaml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,19 +96,30 @@
9696
</Grid.ColumnDefinitions>
9797
<ContentPresenter x:Name="LeftContentPresenter" ContentTemplate="{TemplateBinding TabStripHeaderTemplate}" Content="{TemplateBinding TabStripHeader}" Grid.Column="0"/>
9898
<primitiveContract7Present:TabViewListView x:Name="TabListView" AllowDrop="{TemplateBinding AllowDropTabs}" CanReorderItems="{TemplateBinding CanReorderTabs}" Grid.Column="1" CanDragItems="{TemplateBinding CanDragTabs}" ItemTemplate="{TemplateBinding TabItemTemplate}" ItemsSource="{TemplateBinding TabItemsSource}" ItemTemplateSelector="{TemplateBinding TabItemTemplateSelector}"/>
99-
<Button x:Name="AddButton" Command="{TemplateBinding AddTabButtonCommand}" CommandParameter="{TemplateBinding AddTabButtonCommandParameter}" Content="&#xE710;" Grid.Column="2" Style="{StaticResource TabViewButtonStyle}" Visibility="{Binding IsAddTabButtonVisible, RelativeSource={RelativeSource Mode=TemplatedParent}}"/>
99+
<Button x:Name="AddButton" Command="{TemplateBinding AddTabButtonCommand}" CommandParameter="{TemplateBinding AddTabButtonCommandParameter}" Content="&#xE710;" Grid.Column="2" Style="{StaticResource TabViewButtonStyle}" Visibility="{Binding IsAddTabButtonVisible, RelativeSource={RelativeSource Mode=TemplatedParent}}" HorizontalAlignment="Stretch" VerticalAlignment="Stretch"/>
100100
<Grid Background="Transparent" Name="DragArea" Loaded="DragArea_Loaded" Grid.Column="3"/>
101+
101102
</Grid>
102-
<ContentPresenter x:Name="TabContentPresenter" BorderThickness="{TemplateBinding BorderThickness}" BorderBrush="{TemplateBinding BorderBrush}" Grid.Row="1"/>
103+
<!--<ContentPresenter x:Name="TabContentPresenter" BorderThickness="{TemplateBinding BorderThickness}" BorderBrush="{TemplateBinding BorderBrush}" Grid.Row="1"/>-->
103104
</Grid>
104105
</ControlTemplate>
105106
</Setter.Value>
106107
</Setter>
107108
</Style>
108109
</Page.Resources>
109110

110-
<Grid Name="rootGrid" Background="Transparent">
111-
<uilib:TabView Background="{StaticResource SystemControlAcrylicWindowBrush}" AddTabButtonClick="TabStrip_AddTabButtonClick" Style="{StaticResource TabViewStyleFixed}" SelectionChanged="TabStrip_SelectionChanged" TabCloseRequested="TabStrip_TabCloseRequested" CanDragTabs="False" AllowDropTabs="False" Grid.ColumnSpan="3" CanReorderTabs="True" Name="TabStrip" TabWidthMode="Equal" VerticalAlignment="Stretch">
111+
<Grid Background="{StaticResource SystemControlAcrylicWindowBrush}" Name="rootGrid" >
112+
<Grid.RowDefinitions>
113+
<RowDefinition Height="Auto"/>
114+
<RowDefinition Height="*"/>
115+
</Grid.RowDefinitions>
116+
<Grid.ColumnDefinitions>
117+
<ColumnDefinition Width="*"/>
118+
<ColumnDefinition Width="175"/>
119+
</Grid.ColumnDefinitions>
120+
<ContentPresenter Background="{StaticResource ApplicationPageBackgroundThemeBrush}" x:Name="ContentPresenter" Grid.Row="1" Grid.ColumnSpan="2" Content="{x:Bind ((uilib:TabViewItem)(local:InstanceTabsView).TabStrip.SelectedItem).Content, Mode=OneWay}"/>
121+
122+
<uilib:TabView Background="Transparent" Grid.Row="0" AddTabButtonClick="TabStrip_AddTabButtonClick" Style="{StaticResource TabViewStyleFixed}" SelectionChanged="TabStrip_SelectionChanged" TabCloseRequested="TabStrip_TabCloseRequested" CanDragTabs="False" AllowDropTabs="False" CanReorderTabs="True" Name="TabStrip" TabWidthMode="Equal" VerticalAlignment="Stretch">
112123
<uilib:TabView.Resources>
113124
<ResourceDictionary>
114125
<ResourceDictionary.ThemeDictionaries>

Files UWP/InstanceTabsView.xaml.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ namespace Files
1919
public sealed partial class InstanceTabsView : Page
2020
{
2121
public TabView tabView;
22-
public List<Type> types = new List<Type>();
2322
public InstanceTabsView()
2423
{
2524
this.InitializeComponent();
@@ -236,6 +235,7 @@ private void TabStrip_SelectionChanged(object sender, SelectionChangedEventArgs
236235
}
237236
}
238237
}
238+
239239
}
240240

241241
private void TabStrip_TabCloseRequested(Microsoft.UI.Xaml.Controls.TabView sender, Microsoft.UI.Xaml.Controls.TabViewTabCloseRequestedEventArgs args)
@@ -258,13 +258,4 @@ private void TabStrip_AddTabButtonClick(TabView sender, object args)
258258
}
259259
}
260260

261-
public class InstanceTabItem
262-
{
263-
public string HeaderText { get; set; }
264-
public string SourcePage { get; set; }
265-
public int index { get; set; }
266-
public Frame TabContent { get; set; }
267-
268-
269-
}
270261
}

0 commit comments

Comments
 (0)