Fix: Tag icons may use the wrong color

Author: ferrariofilippo

src/Files.App.Controls/ThemedIcon/ThemedIcon.Properties.cs

@@ -32,6 +32,7 @@ protected virtual void OnOutlineIconPropertyChanged(string oldValue, string newV
 		protected virtual void OnColorPropertyChanged(Brush oldValue, Brush newValue)
 		{
 			OnIconTypeChanged();
+			UpdateColor(newValue);
 		}
 
 		protected virtual void OnIconTypePropertyChanged(ThemedIconTypes oldValue, ThemedIconTypes newValue)

src/Files.App.Controls/ThemedIcon/ThemedIcon.cs

@@ -240,5 +240,14 @@ private void OnIsEnabledChanged(object sender, DependencyPropertyChangedEventArg
 		{
 			UpdateVisualStates();
 		}
+
+		private void UpdateColor(Brush newColor)
+		{
+			if (GetTemplateChild(OutlineIconPath) is Path outlinePath)
+				outlinePath.Fill = newColor;
+
+			if (GetTemplateChild(FilledIconPath) is Path fillPath)
+				fillPath.Fill = newColor;
+		}
 	}
 }

src/Files.App.Controls/ThemedIcon/ThemedIcon.xaml

@@ -150,8 +150,8 @@
 								</VisualState>
 								<VisualState x:Name="Custom">
 									<VisualState.Setters>
-										<Setter Target="PART_OutlinePath.Fill" Value="{Binding RelativeSource={RelativeSource Mode=TemplatedParent}, Path=Color}" />
-										<Setter Target="PART_FilledPath.Fill" Value="{Binding RelativeSource={RelativeSource Mode=TemplatedParent}, Path=Color}" />
+										<Setter Target="PART_OutlinePath.Fill" Value="{Binding Color, Mode=OneTime}" />
+										<Setter Target="PART_FilledPath.Fill" Value="{Binding Color, Mode=OneTime}" />
 									</VisualState.Setters>
 								</VisualState>
 								<VisualState x:Name="Toggle">