Skip to content

Commit f8eb959

Browse files
Update localization strings in SortAction.cs
Refactor localization for sorting actions to use a centralized Strings class instead of hardcoded keys. This change enhances maintainability and consistency across various sorting options, including name, date modified, date created, size, file type, sync status, file tag, path, original folder, date deleted, and sorting direction (ascending and descending).
1 parent 5fad257 commit f8eb959

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

src/Files.App/Actions/Display/SortAction.cs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ protected override SortOption SortOption
99
=> SortOption.Name;
1010

1111
public override string Label
12-
=> "Name".GetLocalizedResource();
12+
=> Strings.Name.GetLocalizedResource();
1313

1414
public override string Description
15-
=> "SortByNameDescription".GetLocalizedResource();
15+
=> Strings.SortByNameDescription.GetLocalizedResource();
1616
}
1717

1818
internal sealed partial class SortByDateModifiedAction : SortByAction
@@ -21,10 +21,10 @@ protected override SortOption SortOption
2121
=> SortOption.DateModified;
2222

2323
public override string Label
24-
=> "DateModifiedLowerCase".GetLocalizedResource();
24+
=> Strings.DateModifiedLowerCase.GetLocalizedResource();
2525

2626
public override string Description
27-
=> "SortByDateModifiedDescription".GetLocalizedResource();
27+
=> Strings.SortByDateModifiedDescription.GetLocalizedResource();
2828
}
2929

3030
internal sealed partial class SortByDateCreatedAction : SortByAction
@@ -33,10 +33,10 @@ protected override SortOption SortOption
3333
=> SortOption.DateCreated;
3434

3535
public override string Label
36-
=> "DateCreated".GetLocalizedResource();
36+
=> Strings.DateCreated.GetLocalizedResource();
3737

3838
public override string Description
39-
=> "SortByDateCreatedDescription".GetLocalizedResource();
39+
=> Strings.SortByDateCreatedDescription.GetLocalizedResource();
4040
}
4141

4242
internal sealed partial class SortBySizeAction : SortByAction
@@ -45,10 +45,10 @@ protected override SortOption SortOption
4545
=> SortOption.Size;
4646

4747
public override string Label
48-
=> "Size".GetLocalizedResource();
48+
=> Strings.Size.GetLocalizedResource();
4949

5050
public override string Description
51-
=> "SortBySizeDescription".GetLocalizedResource();
51+
=> Strings.SortBySizeDescription.GetLocalizedResource();
5252
}
5353

5454
internal sealed partial class SortByTypeAction : SortByAction
@@ -57,10 +57,10 @@ protected override SortOption SortOption
5757
=> SortOption.FileType;
5858

5959
public override string Label
60-
=> "Type".GetLocalizedResource();
60+
=> Strings.Type.GetLocalizedResource();
6161

6262
public override string Description
63-
=> "SortByTypeDescription".GetLocalizedResource();
63+
=> Strings.SortByTypeDescription.GetLocalizedResource();
6464
}
6565

6666
internal sealed partial class SortBySyncStatusAction : SortByAction
@@ -69,10 +69,10 @@ protected override SortOption SortOption
6969
=> SortOption.SyncStatus;
7070

7171
public override string Label
72-
=> "SyncStatus".GetLocalizedResource();
72+
=> Strings.SyncStatus.GetLocalizedResource();
7373

7474
public override string Description
75-
=> "SortBySyncStatusDescription".GetLocalizedResource();
75+
=> Strings.SortBySyncStatusDescription.GetLocalizedResource();
7676

7777
protected override bool GetIsExecutable(ContentPageTypes pageType)
7878
=> pageType is ContentPageTypes.CloudDrive;
@@ -84,10 +84,10 @@ protected override SortOption SortOption
8484
=> SortOption.FileTag;
8585

8686
public override string Label
87-
=> "FileTags".GetLocalizedResource();
87+
=> Strings.FileTags.GetLocalizedResource();
8888

8989
public override string Description
90-
=> "SortByTagDescription".GetLocalizedResource();
90+
=> Strings.SortByTagDescription.GetLocalizedResource();
9191
}
9292

9393
internal sealed partial class SortByPathAction : SortByAction
@@ -96,10 +96,10 @@ protected override SortOption SortOption
9696
=> SortOption.Path;
9797

9898
public override string Label
99-
=> "Path".GetLocalizedResource();
99+
=> Strings.Path.GetLocalizedResource();
100100

101101
public override string Description
102-
=> "SortByPathDescription".GetLocalizedResource();
102+
=> Strings.SortByPathDescription.GetLocalizedResource();
103103

104104
protected override bool GetIsExecutable(ContentPageTypes pageType)
105105
=> pageType is ContentPageTypes.SearchResults;
@@ -111,10 +111,10 @@ protected override SortOption SortOption
111111
=> SortOption.OriginalFolder;
112112

113113
public override string Label
114-
=> "OriginalFolder".GetLocalizedResource();
114+
=> Strings.OriginalFolder.GetLocalizedResource();
115115

116116
public override string Description
117-
=> "SortByOriginalFolderDescription".GetLocalizedResource();
117+
=> Strings.SortByOriginalFolderDescription.GetLocalizedResource();
118118

119119
protected override bool GetIsExecutable(ContentPageTypes pageType)
120120
=> pageType is ContentPageTypes.RecycleBin;
@@ -126,10 +126,10 @@ protected override SortOption SortOption
126126
=> SortOption.DateDeleted;
127127

128128
public override string Label
129-
=> "DateDeleted".GetLocalizedResource();
129+
=> Strings.DateDeleted.GetLocalizedResource();
130130

131131
public override string Description
132-
=> "SortByDateDeletedDescription".GetLocalizedResource();
132+
=> Strings.SortByDateDeletedDescription.GetLocalizedResource();
133133

134134
protected override bool GetIsExecutable(ContentPageTypes pageType)
135135
=> pageType is ContentPageTypes.RecycleBin;
@@ -190,10 +190,10 @@ internal sealed partial class SortAscendingAction : ObservableObject, IToggleAct
190190
private readonly IDisplayPageContext context;
191191

192192
public string Label
193-
=> "Ascending".GetLocalizedResource();
193+
=> Strings.Ascending.GetLocalizedResource();
194194

195195
public string Description
196-
=> "SortAscendingDescription".GetLocalizedResource();
196+
=> Strings.SortAscendingDescription.GetLocalizedResource();
197197

198198
public bool IsOn
199199
=> context.SortDirection is SortDirection.Ascending;
@@ -225,10 +225,10 @@ internal sealed partial class SortDescendingAction : ObservableObject, IToggleAc
225225
private readonly IDisplayPageContext context;
226226

227227
public string Label
228-
=> "Descending".GetLocalizedResource();
228+
=> Strings.Descending.GetLocalizedResource();
229229

230230
public string Description
231-
=> "SortDescendingDescription".GetLocalizedResource();
231+
=> Strings.SortDescendingDescription.GetLocalizedResource();
232232

233233
public bool IsOn
234234
=> context.SortDirection is SortDirection.Descending;
@@ -260,10 +260,10 @@ internal sealed class ToggleSortDirectionAction : IAction
260260
private readonly IDisplayPageContext context;
261261

262262
public string Label
263-
=> "ToggleSortDirection".GetLocalizedResource();
263+
=> Strings.ToggleSortDirection.GetLocalizedResource();
264264

265265
public string Description
266-
=> "ToggleSortDirectionDescription".GetLocalizedResource();
266+
=> Strings.ToggleSortDirectionDescription.GetLocalizedResource();
267267

268268
public ToggleSortDirectionAction()
269269
{

0 commit comments

Comments
 (0)