Skip to content

Commit fe57c4f

Browse files
committed
Use ide friendly name
1 parent 5e097d1 commit fe57c4f

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/Files.App/Actions/Open/OpenInIDEAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public async Task ExecuteAsync(object? parameter = null)
3939
);
4040

4141
if (!res)
42-
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEPath);
42+
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEFriendlyName);
4343
}
4444

4545
private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Actions/Open/OpenRepoInIDEAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public async Task ExecuteAsync(object? parameter = null)
3636
);
3737

3838
if (!res)
39-
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEPath);
39+
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEFriendlyName);
4040
}
4141

4242
private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Helpers/Dialog/DynamicDialogFactory.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,13 +405,13 @@ public static DynamicDialog GetFor_CreateAlternateDataStreamDialog()
405405
return dialog;
406406
}
407407

408-
public static async Task ShowFor_IDEErrorDialog(string path)
408+
public static async Task ShowFor_IDEErrorDialog(string friendlyName)
409409
{
410410
var commands = Ioc.Default.GetRequiredService<ICommandManager>();
411411
var dialog = new DynamicDialog(new DynamicDialogViewModel()
412412
{
413-
TitleText = string.Format(Strings.IDENotLocatedTitle.GetLocalizedResource(), path),
414-
SubtitleText = Strings.IDENotLocatedContent.GetLocalizedResource(),
413+
TitleText = Strings.IDENotLocatedTitle.GetLocalizedResource(),
414+
SubtitleText = string.Format(Strings.IDENotLocatedContent.GetLocalizedResource(), friendlyName),
415415
PrimaryButtonText = Strings.OpenSettings.GetLocalizedResource(),
416416
SecondaryButtonText = Strings.Close.GetLocalizedResource(),
417417
DynamicButtons = DynamicDialogButtons.Primary | DynamicDialogButtons.Secondary,

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4056,10 +4056,10 @@
40564056
<value>Test</value>
40574057
</data>
40584058
<data name="IDENotLocatedContent" xml:space="preserve">
4059-
<value>The configured IDE cannot be located. Please update the path and try again.</value>
4059+
<value>{0} could not be located. Please check your settings and try again.</value>
40604060
</data>
40614061
<data name="IDENotLocatedTitle" xml:space="preserve">
4062-
<value>{0} could not be located</value>
4062+
<value>The configured IDE could not be located</value>
40634063
</data>
40644064
<data name="OpenSettings" xml:space="preserve">
40654065
<value>Open settings</value>

0 commit comments

Comments
 (0)