Bug: Path breadcrumb alignment is off except last segment

[foriequal0]

Description

The last segment seems to be aligned while the previous segments aren't.

I think TextLineBounds = Full here makes all text alignment a little bit off, especially for non-latin languages:

Files/src/Files.App/ResourceDictionaries/App.Theme.TextBlockStyles.xaml

Line 11 in c6ad49c

<Setter Property="TextLineBounds" Value="Full" />

And I think this is why manual Padding adjustments are prevalent here and there:
https://github.com/search?q=repo%3Afiles-community%2FFiles%20padding&type=code
including the last segment of the path breadcrumb:

Files/src/Files.App/UserControls/PathBreadcrumb.xaml

Line 71 in c6ad49c

Padding="0,4"

We might be able to utilize the typographic options.
https://blogs.windows.com/windowsdeveloper/2013/11/11/xaml-text-improvements-in-windows-8-1/
I believe that it would make the app more resilient to font-related alignment issues.

I think this is the right place to do:

Files/src/Files.App/ResourceDictionaries/App.Theme.TextBlockStyles.xaml

Line 4 in c6ad49c

<Style x:Key="App.Theme.BaseTextBlockStyle" TargetType="TextBlock">

Steps To Reproduce

1. Navigate to some directories
2. See path segments

Requirements

Baselines should be aligned.

Files Version

3.2.0.0

Windows Version

Windows 11, 23H2, 22631.3155

Log File

[yaira2]

Thank you for your feedback, I think this is due to the bold font style.

[0x5bfa]

@yaira2 A bit off. We could make a fix.

Recording.2024-02-15.014433.mp4

[foriequal0]

Thanks! I'll add some more examples here.

• search box
  

• texts in the sidebar, tooltips
  

I think when Padding is manually adjusted for "Segoe UI" and 100% scale, non-Latin texts look off, and when isn't, Latin texts look off.

[0x5bfa]

It seems that this also happens in Japanese.

[0x5bfa]

@yaira2 Confirmed that using Segoe UI Variable fixes this perfectly. Hopefully looks like they made it default in v1.6 of WASDK. We can close I think.

[yaira2]

Great!

[yaira2]

@foriequal0 this issue should be resolved when the WinAppSdk framework is updated to 1.6. This depends on Microsoft's timeline but it should in the next few months.