Skip to content

Conversation

@Iweisc
Copy link

@Iweisc Iweisc commented Oct 12, 2024

I made the read me better, Its friendly and easy to understand.

@0x5bfa
Copy link
Member

0x5bfa commented Oct 12, 2024

Thanks for your contribution.

🤝 Contributing

  1. Review our contributing guidelines.

Contributions we accept

  • DO create one pull request per Issue, and ensure that the Issue is linked in the pull request.
  • DO link the issue you are addressing in the pull request.
  • DO NOT submit a PR unless it the connected issue is marked as ready to build or approved indirectly by an org member. This enables us to have a discussion on the idea before anyone invests time on the implementation.

As you outlined this, we accept PRs that are linked to respective issue to avoid wasting your and our time. I suggest to discuss with @yaira2 first and foremost.


In my honest opinion, adding emojis looks off and the current README keeps the best simplicity.

@Iweisc Iweisc closed this Oct 12, 2024
@Iweisc Iweisc reopened this Oct 12, 2024
@Iweisc
Copy link
Author

Iweisc commented Oct 12, 2024

In my honest opinion, adding emojis looks off and the current README keeps the best simplicity.

But its not simple most of the users are not familiar with github. and the current read me just kinda feels off

@0x5bfa
Copy link
Member

0x5bfa commented Oct 12, 2024

We only accept PRs that are approved either directly or indirectly because otherwise it'd waste time of both sides. We appreciate the contribution but this is clearly phrased out in our contribution guidelines. Please open an issue first and then let's discuss.

As Josh and Yair seem to be offline and given that it's weekend, let me close this for now.

@0x5bfa 0x5bfa closed this Oct 12, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 13, 2024

Hey @coderzawad, thanks for the PR! 😊 As @0x5bfa mentioned, linking to an approved issue is usually a good idea. It's not a hard rule, but it helps everyone by reducing extra work. You can look at the contributing section of the readme https://github.com/files-community/Files?tab=readme-ov-file#contributing-to-files to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants