Fix: Fixed issue where soft link details were misaligned in git repos

[ashrafmansuri]

Resolved / Related Issues

• Closes Bug: Soft link file details layout information misaligned #15998

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Opened Files
2. Create a soft link in a git repo.
3. Change to detail layout.
4. check the information alignment.

[ashrafmansuri]

From my observation if (isSymlink) is called before else if (isGitRepo), isGitRepo is true so I have just added a check in the isSymlink block.

[ashrafmansuri]

The icon is different which can be changed. By adding properties to GitItem(). Hopefully by tomorrow, something's wrong with my VS. Can I get this issue assigned to me? And if any other review please let me know.

[hishitetsu]

This still leaves the alignment wrong for shortcut files (.lnk and .url).
I don't believe this approach is correct. The problem is that ShortcutItem doesn't support Git repositories, so we should create something like GitShortcutItem.

[0x5bfa]

@ashrafmansuri Look at my earlier comment #15998 (comment)

[ashrafmansuri]

This still leaves the alignment wrong for shortcut files (.lnk and .url).

I don't believe this approach is correct. The problem is that ShortcutItem doesn't support Git repositories, so we should create something like GitShortcutItem.

Alright. Understood.

[ashrafmansuri]

@ashrafmansuri Look at my earlier comment #15998 (comment)

Yes I saw that. Your comment helped me a lot. So should I check for isGitRepo before or should I create a new item as suggested by @hishitetsu ?

[0x5bfa]

Yeah. Create a new class that derives from both ShortcutItem and GitItem named GitShortcutItem while this isn't ideal way.

[ashrafmansuri]

I'll create a new pull request