Skip to content

Conversation

@Pinguin2001
Copy link

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files
  2. Extract a 7z archive
  3. Verify the archive has been extracted correctly

@yaira2
Copy link
Member

yaira2 commented Dec 8, 2024

@Pinguin2001 For security reasons, I'll need to add the DLLs myself. Thank you so much for bringing this to our attention and taking the time to open a PR! I'll try to wrap this up in time for the next version of Files.

@yaira2 yaira2 closed this Dec 8, 2024
@Pinguin2001
Copy link
Author

@Pinguin2001 For security reasons, I'll need to add the DLLs myself. Thank you so much for bringing this to our attention and taking the time to open a PR! I'll try to wrap this up in time for the next version of Files.

Okay, no problem.
Well you could validate the SHA-256 Hashes with the 7z.dll contained in

https://7-zip.org/a/7z2409-x64.exe
https://7-zip.org/a/7z2409.exe
https://7-zip.org/a/7z2409-arm64.exe

The DLLs have been copied as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Quality: Files is still using 7z 21.01 Alpha

2 participants