Bug: Opening Storage Sense causes NullReferenceException

[sentry]

Sentry Issue: FILES-APP-2VP

System.NullReferenceException: Object reference not set to an instance of an object.
  ?, in HRESULT IApplicationActivationManager.ActivateApplication(string appUserModelId, string arguments, ACTIVATEOPTIONS options, out uint processId)
  ?, in void LaunchHelper.LaunchSettings(string page)
  ?, in async Task StorageSenseHelper.OpenStorageSenseAsync(string path)
  ?, in async void DrivesWidget.GoToStorageSense_Click(object sender, RoutedEventArgs e)
...
(1 additional frame(s) were not displayed)

[ferrariofilippo]

Why are we showing Open Storage Sense for drives that are not the System Drive?
According to MS that is the only one supported.

[0x5bfa]

Yes, I fully agree with you, I've said the same thing before in https://discord.com/channels/725513575971684472/958783217941487616/1205538416301838396

[0x5bfa]

Omg, I've missed, this code is totally wrong and of course causes a null ref. You have to CoCreateInstance for this interface manually.

Files/src/Files.App/Utils/Shell/LaunchHelper.cs

Line 21 in 2aab17e

var appActiveManager = new IApplicationActivationManager();

[Josh65-2201]

It could be changed to go to the storage overviews of the drive as they all have this

[0x5bfa]

Bringing this problem is a good idea, should we open an issue or will we discuss on discord? @yaira2

FYI @Jack251970, here's the fix of this exception, would you like to fix?

using ComPtr<IApplicationActivationManager> pApplicationActivationManager = default;
pApplicationActivationManager.CoCreateInstance<ApplicationActivationManager>();

pApplicationActivationManager.Get()->ActivateApplication(
    "windows.immersivecontrolpanel_cw5n1h2txyewy!microsoft.windows.immersivecontrolpanel",
    page,
    ACTIVATEOPTIONS.AO_NONE,
    out _);

[Jack251970]

@0x5bfa So sorry for that! Already fixed in #16606.

[yaira2]

Why are we showing Open Storage Sense for drives that are not the System Drive? According to MS that is the only one supported.

The behavior depends on the drive type. On system drives it'll open storage sense, and other drives will open the storage overview page.

[0x5bfa]

I mean, the wording is wrong. You cannot actually storage sense manually but just see drive usage overview or configure to run storage sense on startup of windows. Should be "Free up the storage" imo.