Fix: Fixed issue where soft link details were misaligned in git repos

[ashrafmansuri]

• Closes Bug: Soft link file details layout information misaligned #15998

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Opened Files ...
2. Create a link in git repo.
3. Change to detail view.
4. Check the alignment.

[ashrafmansuri]

I have created 2 interfaces and substituted in place of GitItem, fixes the alignment issue but unable to get the icon property. Need some help to figure it out.

[0x5bfa]

Thank you for your PR!

We use if (item is ShortcutItem) {} a lot so it's important to inherit from ShortcutItem class:

public sealed class GitShortcutItem : ShortcutItem, GitItem {}

Okay, should I discard the previous changes?

Just like this:

if (isSymLink)
{
    if (isGitRepo) { return new() { ... }; }
    else { return new() { ... }; }
}

[ashrafmansuri]

Thank you for your PR!

We use if (item is ShortcutItem) {} a lot so it's important to inherit from ShortcutItem class:

public sealed class GitShortcutItem : ShortcutItem, GitItem {}

To inherit from ShortcutItem and GitItem I'll have to remove the sealed keyword. This is the reason I created interfaces.

Okay, should I discard the previous changes?

Just like this:

if (isSymLink)

{

    if (isGitRepo) { return new() { ... }; }

    else { return new() { ... }; }

}

[0x5bfa]

Seal was added for IL compiler performance aspects, you can remove any time you want.

[ashrafmansuri]

Seal was added for IL compiler performance aspects, you can remove any time you want.

Okay. Understood, thank you. Will do today.

[0x5bfa]

You don't need interfaces you introduced.

[ashrafmansuri]

You don't need interfaces you introduced.

I won't be able to inherit ShortcutItem and GitItem together. That's why I used interfaces.

[0x5bfa]

Ahh you're absolutely right, I forgot that.

Can you change "is/as ShortcutItem" to IShortcutItem in everywhere as well in that case? Then you dint have to inherit ShortcutItem and GitItem but should inherit these two interfaces.

[ashrafmansuri]

Ahh you're absolutely right, I forgot that.

Can you change "is/as ShortcutItem" to IShortcutItem in everywhere as well in that case? Then you dint have to inherit ShortcutItem and GitItem but should inherit these two interfaces.

Sure thing I'll carefully substitute IShortcutItem in the place of ShortcutItem.

[ashrafmansuri]

I have replaced all "Is Shortcut" Item with interface so that it checks for the interface properties, I have not changes "as ShortcutItem" because it might want to actually create an Instance of the class rather than the Interface as the ShortcutItem is being derived from ListedItem class also.

[ashrafmansuri]

Ahh you're absolutely right, I forgot that.

Can you change "is/as ShortcutItem" to IShortcutItem in everywhere as well in that case? Then you dint have to inherit ShortcutItem and GitItem but should inherit these two interfaces.

I've made the commits! :)

[yaira2]

LGTM