Skip to content

Conversation

@Lamparter
Copy link
Contributor

Resolved / Related Issues

Not worth opening another issue


Makes the CI/CD workflow names a bit more concise.

  • build is now Build to be consistent
  • CD targets (Store Stable, Store Preview, etc.) are now part of the matrix
    Before: Files CD (Store Stable) / Deploy (Release, x64)
    After: Files CD / Deploy (Store Stable, Release, x64)
    

Before: Files CD (Store Stable) / Deploy (Release, x64)
After: Files CD / Deploy (Store Stable, Release, x64)
@Lamparter
Copy link
Contributor Author

Looks like I broke the branch protection rule by renaming the CI 😄

@0x5bfa
Copy link
Member

0x5bfa commented Jan 13, 2025

I'm not in favor of this change at all.

@Lamparter
Copy link
Contributor Author

Why not?

@0x5bfa
Copy link
Member

0x5bfa commented Jan 13, 2025

Because there are gonna be just 2 workflows, Files CI and Files CD. We have 4 workflows but they should really be merged. Besides upper case or lower case deadens on preferences

@Lamparter
Copy link
Contributor Author

The capitalisation is inconsistent with the CodeQL workflows
For now I can change the capitalisation on the CodeQL instead for it to all be lowercase

@0x5bfa
Copy link
Member

0x5bfa commented Jan 14, 2025

Doesn't matter, as far as it works, we should not change anything.

@0x5bfa
Copy link
Member

0x5bfa commented Jan 14, 2025

This is how it's gonna be, I made a build script that covers all configurations.
CC @yaira2

@yaira2
Copy link
Member

yaira2 commented Jan 14, 2025

Changes to actions and similar tasks are currently on hold. Although it would be beneficial to improve these areas, our resources are limited, particularly with code review. Therefore, our focus is primarily on bug fixes and feature development. I don't have an exact timetable, but we should be able to put more time into these areas once the issue count is significantly lower.

@0x5bfa
Copy link
Member

0x5bfa commented Jan 14, 2025

Yep that's why I even didn't open a PR (I made that branch a month ago).

@Lamparter Lamparter closed this Jan 14, 2025
@Lamparter Lamparter deleted the concise-ci branch January 14, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants