Code Quality: Upgrade from legacy WCT to WCT 8.x

[Lamparter]

Description

Currently, Files has a large dependency on the old CommunityToolkit.WinUI.UI.* packages.
These do not support NativeAOT and are deprecated.
They should be upgraded to WCT 8.x

Concerned code

• Lots of classes rely on legacy helpers and converters

Gains

• Native AOT compilation / trimming
• Better experience as newer packages are optimised and up to date

Requirements

• Upgrade existing infrastructure
• Port to new or recreated controls
• Help along in collaboration with WCT to port what Files needs to 8.x

Comments

@0x5bfa wrote an amazing list of everything that need porting: 0x5bfa/Files.wiki:Migrate-WCT-from-7.x-to-8.x

[Lamparter]

Looks like adding the new Converters package immediately breaks the app - while it builds the splash screen displays indefinitely.

[Jay-o-Way]

If needed, @niels9001 knows all about this subject

[Lamparter]

Thanks! I'm looking forward to working with the Community Toolkit team on what to port/rewrite for use in 8.x

However, right now I'm facing this issue.

Unfortunately, there's an error that occurs with the DP extensions (an ambiguous reference between the extension FindAscending in both 7.x and 8.x)
And every WCT 8.x package relies on the new CommunityToolkit.WinUI.Extensions package that is causing the issue.
So every control must be ported at the same time
Except since BladeView hasn't been ported yet / a different implementation used, upgrading is impossible as of now

[Jay-o-Way]

Fun fact about the BoolToVisibilityConverter: its function is embedded in WinUi 3 😊

[0x5bfa]

Fun fact about the BoolToVisibilityConverter: its function is embedded in WinUi 3 😊

Yeah I was surprised when I was allowed to set the boolean to a Visibility property and it worked perfectly. I wonder when it was added.

[0x5bfa]

Can we work on this from Files.App.Controls?

[Lamparter]

No
It's literally entirely impossible, because of the blocker

[0x5bfa]

FYI https://learn.microsoft.com/nl-nl/windows/uwp/xaml-platform/x-bind-markup-extension#remarks

Starting in Windows 10, version 1607, the XAML framework provides a built in Boolean to Visibility converter. The converter maps true to the Visible enumeration value and false to Collapsed so you can bind a Visibility property to a Boolean without creating a converter.