Feature: Use DPI aware icons in the Details View and List View layouts #16708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
force-pushed
the
ya/DetailsViewDPI
branch
from
3b44ca2 to
b80fa47
Compare
hishitetsu
reviewed
Jan 15, 2025
yaira2
commented
Jan 16, 2025
Member
Author
There was a problem hiding this comment.
I moved the code for getting the icon size to LayoutSizeKindHelper.cs.
yaira2
commented
Jan 16, 2025
yaira2
commented
Jan 16, 2025
yaira2
changed the title
hishitetsu
reviewed
Jan 16, 2025
Co-authored-by: hishitetsu <[email protected]> Signed-off-by: Yair <[email protected]>
Co-authored-by: hishitetsu <[email protected]> Signed-off-by: Yair <[email protected]>
Co-authored-by: hishitetsu <[email protected]> Signed-off-by: Yair <[email protected]>
Co-authored-by: hishitetsu <[email protected]> Signed-off-by: Yair <[email protected]>
Co-authored-by: hishitetsu <[email protected]> Signed-off-by: Yair <[email protected]>
yaira2
added
the
ready to merge
Member
Author
|
@hishitetsu thank you for the code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.