Bug: Permissions list is missing bottom margin

[chausner]

Description

For very long user/group names in the security properties dialog, when they break into two or more lines, there is no top/bottom margin between the text and its parent list view item. See e.g.:

Steps To Reproduce

1. Select a folder
2. Click on "Properties"
3. Open tab "Security"

Files Version

3.9.1.0

Windows Version

10.0.26120.3281

User ID

2f32e95c-0619-48d3-afcf-bf1499b64b53

Log File

[yaira2]

Can you clarify what you expect the behavior to be?

[chausner]

There should be some top and bottom margin so that the text doesn't touch the border of the list view. Like so:

[mdtauk]

The items as you scroll to the bottom of the list, is too close to the bottom border

[chausner]

To be specific, this TextBlock probably needs some top and bottom margin set: https://github.com/files-community/Files/blob/1c25e81a9525d3598517c9c1147d24ee47cdc03d/src/Files.App/Views/Properties/SecurityPage.xaml#L153C10-L159C22

It's not about the bottom of the ListView, it's actually about the vertical margins between the TextBlock and the parent ListViewItem. When the text is a single-line, there is an implicit margin but when the text becomes two (or more lines), the text gets too close to the border of the ListViewItem.

[chausner]

But thinking more about it, I think the visual effect as seen in my first posted image will still be possible. Depending on the vertical scroll position of the ListView, it is always possible that text appears to touch the border of the ListView control, whether there are margins or not.

But you might still want to add some margins to the TextBlock, it probably makes it look a bit better when the concerned item is selected.

[yaira2]

We should really do two things

• add a margin to the bottom of the ListView
• disable wrapping on the TextBlock