Skip to content

Conversation

@SuggonM
Copy link

@SuggonM SuggonM commented Feb 28, 2025

This PR includes minor changes related to grammar consistency in the string files.

Resolved / Related Issues

N/A

Steps used to test these changes

N/A

@SuggonM SuggonM marked this pull request as ready for review February 28, 2025 07:41
@yaira2
Copy link
Member

yaira2 commented Feb 28, 2025

Thank you for your contribution! Updates to the translations are managed through our Crowdin project at https://crowdin.com/project/files-app. Feel free to reach out if you have any questions.

@yaira2 yaira2 closed this Feb 28, 2025
@0x5bfa
Copy link
Member

0x5bfa commented Feb 28, 2025

I think this was meant to update only en-US resources.

@SuggonM
Copy link
Author

SuggonM commented Mar 1, 2025

Thanks, I wasn't aware the translations were being managed from a different location.

I've found the string in question in Crowdin, but it seems the system will require someone with elevated rights to be able to modify the source string itself. Would it be better to let the right people take the action? (cc @yaira2 @0x5bfa)

  1. https://crowdin.com/editor/files-app/34/en-engb#q=Moves
  2. https://crowdin.com/editor/files-app/34/en-engb#q=Closes
pointing out the grammar inconsistency: <close> and <closes>

@SuggonM SuggonM deleted the patch-1 branch March 1, 2025 01:53
@0x5bfa
Copy link
Member

0x5bfa commented Mar 1, 2025

I mean, I think you meant to edit only en-US resources. Crowdin automatically reflects the change to other languages. @yaira2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants