Code Quality: Use ComPtr for all D3D11 pointers #16908
Conversation
|
@hez2010 What and where exactly was the issue that caused the crash in Preview Pane? Looks like this PR has a crash when disposing CEOL again. Perhaps should I dispose these com objects manually? |
Some resources shouldn't be released eagerly when the visual content is still visible. |
|
I disposed an object (pChildVisual) that shouldn't be. Thanks, it looks to be working now. |
0x5bfa
force-pushed
the
5bfa/CQ-ShellPreviewComPtr
branch
from
aa719f3 to
b0b0a2b
Compare
|
@yaira2 Ready. I'm gonna remove Vanara from this area later when i take a break for Omnibar. |
| using ComPtr<IDXGIDevice> pDXGIDevice = default; | ||
| using ComPtr<IDCompositionDevice> pDCompositionDevice = default; | ||
| using ComPtr<IUnknown> pControlSurface = default; | ||
| ComPtr<IDCompositionVisual> pChildVisual = default; // Don't dispose this one, it's used by the compositor |
There was a problem hiding this comment.
It seems that we never release it and would cause memory leaking. I think we should do something around this to free it eventually when user switched or closed the preview pane.
There was a problem hiding this comment.
this was what it was though. however, we can make this to a class-level field and dispose when disposing CEOL?
yaira2
added
ready to merge
|
@hez2010 I just tried to dispose pChildVisual but it seems to be already disposed by CEOL. What should we do, shoul we leave as was?
FWIW, swapping the line of disposing CEOL and that of disposing pChildVisual causes the same crash in CEOL.Dispose() instead.
|
3 participants
Resolved / Related Issues
General improvements for code that uses raw unmanaged pointers.
Steps used to test these changes
CC @hez2010