Code Quality: Replace custom settings control with Community Toolkit #16989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
force-pushed
the
ya/SettingsControl
branch
from
f24133e to
bf38b4b
Compare
Contributor
|
Does this fix #16348? |
yaira2
force-pushed
the
ya/SettingsControl
branch
from
a8a7158 to
adec2b1
Compare
Member
Author
If it doesn't, we can open an issue on the Toolkit repo. |
yaira2
added
the
ready to merge
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces custom settings controls with their Community Toolkit counterparts to improve code quality and reduce maintenance overhead.
- Removed custom control: SettingsBlockControl
- Removed custom control: SettingsDisplayControl
Reviewed Changes
Copilot reviewed 3 out of 18 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Files.App/UserControls/Settings/SettingsBlockControl.xaml.cs | Entire file removed; ensure new toolkit control provides equivalent behavior |
| src/Files.App/UserControls/Settings/SettingsDisplayControl.xaml.cs | Entire file removed; confirm replacement covers all intended functionalities |
Files not reviewed (15)
- src/Files.App/UserControls/Settings/SettingsBlockControl.xaml: Language not supported
- src/Files.App/UserControls/Settings/SettingsDisplayControl.xaml: Language not supported
- src/Files.App/UserControls/Toolbar.xaml: Language not supported
- src/Files.App/Views/Properties/CompatibilityPage.xaml: Language not supported
- src/Files.App/Views/Properties/GeneralPage.xaml: Language not supported
- src/Files.App/Views/Properties/ShortcutPage.xaml: Language not supported
- src/Files.App/Views/Settings/AboutPage.xaml: Language not supported
- src/Files.App/Views/Settings/ActionsPage.xaml: Language not supported
- src/Files.App/Views/Settings/AdvancedPage.xaml: Language not supported
- src/Files.App/Views/Settings/AppearancePage.xaml: Language not supported
- src/Files.App/Views/Settings/DevToolsPage.xaml: Language not supported
- src/Files.App/Views/Settings/FoldersPage.xaml: Language not supported
- src/Files.App/Views/Settings/GeneralPage.xaml: Language not supported
- src/Files.App/Views/Settings/LayoutPage.xaml: Language not supported
- src/Files.App/Views/Settings/TagsPage.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Files.App/UserControls/Settings/SettingsBlockControl.xaml.cs:1
- [nitpick] Ensure that all functionalities provided by the removed SettingsBlockControl are fully tested with the Community Toolkit replacement. Double-check integration tests to verify that the new control meets the expected behavior.
// Copyright (c) Files Community
src/Files.App/UserControls/Settings/SettingsDisplayControl.xaml.cs:1
- [nitpick] Verify that the full functionality of the removed SettingsDisplayControl is covered by tests in the new Community Toolkit approach. Confirm that the replacement accurately handles all use cases previously managed by this control.
// Copyright (c) Files Community
d80f04c to
42ff867
Compare
yaira2
force-pushed
the
ya/SettingsControl
branch
10 times, most recently
from
6f81dbe to
8e88baa
Compare
yaira2
force-pushed
the
ya/SettingsControl
branch
from
35b062b to
526d565
Compare
yaira2
force-pushed
the
ya/SettingsControl
branch
from
f031451 to
7ad70bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.