Code Quality: Improved Axe assertion message #17283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
approved these changes
Jul 20, 2025
Contributor
marcelwgn
left a comment
marcelwgn
left a comment
There was a problem hiding this comment.
Not sure if the position would necessarily help me debug a failure more easily but the code looks fine.
yaira2
added
ready to merge
Member
Author
|
This PR fails with a unknown AXE issue but because now we know the poisiton of items causing that issue, I figured out that it was caused by an element located in the right top (and presumably Mode buttons not having a11y name.), which was fixed in the other PR. |
Member
|
Why is this failing if no xaml has been changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
None
Steps used to test these changes
None