Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 21, 2024

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 21, 2024

As far as we enable friendlyOverloads and useSafeHandles we don't have to worry about handles and we should use SafeHandle derivatives.

@hez2010 fyi.

@yaira2 yaira2 requested a review from hez2010 September 22, 2024 00:57
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Sep 23, 2024
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@yaira2 yaira2 merged commit 0debeee into files-community:main Sep 30, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Sep 30, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ComHeapPtr branch September 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants