Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Oct 17, 2024

Resolved / Related Issues

None

Steps used to test these changes

None

@0x5bfa
Copy link
Member Author

0x5bfa commented Oct 17, 2024

@yaira2 Fixed the xaml formatting checker and the xaml formatter. Up for review & merge.

I'll run the xaml formatter later in another PR after this is merged since issue_comment event is fired based on the default branch (the main branch) while pull_request event is based on the head branch.

@0x5bfa 0x5bfa added the ready for review Pull requests that are ready for review label Oct 17, 2024
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed ready for review Pull requests that are ready for review labels Oct 28, 2024
@yaira2 yaira2 merged commit 7aa773d into files-community:main Oct 28, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Oct 28, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 28, 2024

LGTM

@0x5bfa 0x5bfa deleted the 5bfa/GH-XStylerFix branch October 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants