Skip to content

Conversation

@Lamparter
Copy link
Contributor

Absolutely miniscule change, but this makes the C++ header files in the Visual C++ projects detected as C++ rather than C as GitHub Linguist assumes.

@Lamparter Lamparter changed the title GitHub: Make C++ headers actually detected as C++ GitHub: Make C++ headers actually detect as C++ Oct 18, 2024
@0x5bfa
Copy link
Member

0x5bfa commented Oct 18, 2024

What if we'd be using C? Better to rename hpp.

@Lamparter
Copy link
Contributor Author

@0x5bfa does the team intend to use C?

@0x5bfa
Copy link
Member

0x5bfa commented Oct 18, 2024

For these? No, it's hard to utilize com from c. I was referring to 'maybe' in the future. (Though I'm pretty sure we should be able to merge these c++ projects into Files.App, registering com in the appxmanifest and opening a window from com classes)

Btw what's the reason to make such change? It doesn't matter and no body cares.

@Lamparter
Copy link
Contributor Author

Btw what's the reason to make such change? It doesn't matter and no body cares.

Yes, you're absolutely right. It was just a small thing that bugged me after a long time of looking at the repo...

But I don't see what's wrong with this PR since it wasn't a lot of effort to fix a small issue.

@0x5bfa
Copy link
Member

0x5bfa commented Oct 18, 2024

It's hard for me to approve and rather don't agree because .h file is both C/C++ and .hpp is specifically for C++.
@yaira2 i'll leave to you.

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 27, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

I don't mind either way.

@yaira2 yaira2 merged commit 8dce810 into files-community:main Oct 27, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 27, 2024
@yaira2
Copy link
Member

yaira2 commented Oct 27, 2024

LGTM

@Lamparter Lamparter deleted the linguist branch October 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants