Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Oct 28, 2024

Resolved / Related Issues

Planned internally

Note

We have planned to move all CI/CD to GHA. However, the CD for Microsoft Store had a workflow that was incompatible with GHA and we haven't been able to migrate (StoreBroker ps module should work for us to upload a msix package).
This introduces a new workflow for the Store CD but doesn't contain steps to upload packages to Microsoft Store via StoreBroker yet. Hence, we still have to upload it manually.

Steps used to test these changes

  1. Merge this
  2. Run the CD and check if the msixupload will be generated.

@Lamparter
Copy link
Contributor

Why is this PR marked as code quality?

@0x5bfa 0x5bfa changed the title Code Quality: Introduce GHA CD to Microsoft Store GitHub: Introduce GHA CD to Microsoft Store Oct 28, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 29, 2024
@yaira2 yaira2 merged commit 5672540 into files-community:main Oct 29, 2024
6 checks passed
@yaira2 yaira2 changed the title GitHub: Introduce GHA CD to Microsoft Store GitHub: Added GitHub workflow to create Microsoft Store package Oct 29, 2024
@0x5bfa 0x5bfa deleted the 5bfa/GH-StoreCD branch October 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants