Skip to content

Conversation

@ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

  1. Click on New
  2. Click on Shortcut
  3. Try to break the modal

Notes
At the moment the Name is updated whenever the destination path changes.

Or alternatively, we only auto fill the name if the field is empty.

I think this may not work as expected:
let's say a user selects SomePath/FileA, then the name will be set to File_A. If now the destination is changed to SomePath/File_B, the name should not be updated according to above (because the field would not be empty).

Screenshot 2024-11-21 214958

@yaira2 yaira2 self-requested a review November 21, 2024 21:14
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 21, 2024
@yaira2
Copy link
Member

yaira2 commented Nov 24, 2024

@ferrariofilippo can you add some space between the location text box and the name section?

@ferrariofilippo
Copy link
Contributor Author

Which one is better?

12dp
image

8dp
image

@yaira2
Copy link
Member

yaira2 commented Nov 26, 2024

@ferrariofilippo let's go with 12px for now.

@yaira2 yaira2 changed the title Feature: Naming a shortcut while creating it Feature: Added support for assigning a custom name when creating a new shortcut Nov 26, 2024
yaira2
yaira2 previously approved these changes Nov 26, 2024
@yaira2 yaira2 requested a review from 0x5bfa November 26, 2024 20:27
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 26, 2024
@yaira2 yaira2 merged commit 5e5e4f3 into files-community:main Nov 27, 2024
6 checks passed
@ferrariofilippo ferrariofilippo deleted the feature_naming_shortcut branch November 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Naming a shortcut while creating it

2 participants