-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Added support for assigning a custom name when creating a new shortcut #16506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaira2
merged 4 commits into
files-community:main
from
ferrariofilippo:feature_naming_shortcut
Nov 27, 2024
Merged
Feature: Added support for assigning a custom name when creating a new shortcut #16506
yaira2
merged 4 commits into
files-community:main
from
ferrariofilippo:feature_naming_shortcut
Nov 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ferrariofilippo can you add some space between the location text box and the name section? |
Contributor
Author
Member
|
@ferrariofilippo let's go with 12px for now. |
yaira2
previously approved these changes
Nov 26, 2024
yaira2
reviewed
Nov 26, 2024
yaira2
reviewed
Nov 26, 2024
yaira2
reviewed
Nov 26, 2024
yaira2
reviewed
Nov 26, 2024
src/Files.App/ViewModels/Dialogs/CreateShortcutDialogViewModel.cs
Outdated
Show resolved
Hide resolved
yaira2
approved these changes
Nov 26, 2024
Member
yaira2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
NewShortcutNotes
At the moment the
Nameis updated whenever the destination path changes.I think this may not work as expected:
let's say a user selects
SomePath/FileA, then the name will be set toFile_A. If now the destination is changed toSomePath/File_B, the name should not be updated according to above (because the field would not be empty).