Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 22, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 22, 2024
@yaira2 yaira2 requested a review from d2dyno1 November 22, 2024 15:27
@d2dyno1
Copy link
Member

d2dyno1 commented Nov 23, 2024

Why not use [Obsolete("")] attribute instead?

@0x5bfa

This comment was marked as off-topic.

@files-community files-community deleted a comment from Sanasahil Nov 24, 2024
@files-community files-community deleted a comment from Sanasahil Nov 24, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 24, 2024
@yaira2 yaira2 merged commit 3b31e72 into files-community:main Nov 24, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-LegacyWindowsStorable branch November 24, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants