-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Added proper support for RTL languages #16514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
XTorLukas
wants to merge
37
commits into
files-community:main
from
XTorLukas:xtorlukas/Featue-RealTimeLayoutUpdate
Closed
Changes from 14 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
ba3d280
CQ: Add Win32 methods
XTorLukas bfc8002
CQ: Create SourceGenerator
XTorLukas 52daef5
Feature: Implemented service `RealTimeLayoutService`
XTorLukas 85b8f95
CQ: Change visibility
XTorLukas e7668e4
CQ: Correct change CurrentCulture
XTorLukas ae06d2d
CQ: Fix DragRegions
XTorLukas 88b8f21
Fix: Use guid in the name
XTorLukas e61ee02
Feature: Add all Dialogs to RealRimeLayout
XTorLukas 46cff34
CQ: Add FilePropertiesPage
XTorLukas 37c35e2
CQ: Fix
XTorLukas 4f551c1
CQ: Add comments
XTorLukas d515296
CQ: Add licence header
XTorLukas 16e8842
CQ: Redesign the code
XTorLukas 58c9adb
CQ: Fix
XTorLukas 0344538
CQ: Add interface for class
XTorLukas 8d5e95f
Fix: Solve problem with null reference
XTorLukas 28e8805
CQ: Updates
XTorLukas 67d6e34
Merge branch 'main' into xtorlukas/Featue-RealTimeLayoutUpdate
XTorLukas dde4c74
CQ: Removal of unnecessary parts
XTorLukas d8c717c
CQ: Set static FlowDirection
XTorLukas 580e4f5
CQ: Update
XTorLukas a0cb941
CQ: Only one create field
XTorLukas 77b7aa2
CQ: Add comments
XTorLukas 2e56817
Fix: Arrows in RTL/LTR not visibility correctly
XTorLukas 37e34a9
CQ: Add for Animated Icon
XTorLukas d591ae3
CQ: Correction
XTorLukas 2a3eac4
CQ: Add gap
XTorLukas 7f7e660
CQ: Turn off RealTime feature
XTorLukas 31440a4
Revert: Gap changes
XTorLukas 596c16e
Merge branch 'xtorlukas/Featue-RealTimeLayoutUpdate' into xtorlukas/F…
XTorLukas ca698e2
CQ: Add Forward & Back arrow correctly
XTorLukas 38e6465
CQ: Add `FlowDirectionChanged` event
XTorLukas d7b8474
Merge branch 'xtorlukas/Fix-WrongArrowInRTL' into xtorlukas/Featue-Re…
XTorLukas 702f84b
CQ: Fix Forward & Back buttons for RTL
XTorLukas 0bd2cd5
Fix
XTorLukas 05b3046
CQ: Fix `MainPropertiesPage` drag area for RTL
XTorLukas 004be1b
CQ: ProgressRing fix in RTL
XTorLukas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright (c) 2024 Files Community | ||
| // Licensed under the MIT License. See the LICENSE. | ||
|
|
||
| namespace Files.App.Data.Contracts | ||
| { | ||
| /// <summary> | ||
| /// Defines an interface for real-time control components that manage content layout updates. | ||
| /// </summary> | ||
| internal interface IRealTimeControl | ||
| { | ||
| /// <summary> | ||
| /// Initializes the content layout for the control. | ||
| /// </summary> | ||
| void InitializeContentLayout(); | ||
|
|
||
| /// <summary> | ||
| /// Updates the content layout of the control. | ||
| /// </summary> | ||
| void UpdateContentLayout(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright (c) 2024 Files Community | ||
| // Licensed under the MIT License. See the LICENSE. | ||
|
|
||
| using Microsoft.UI.Xaml; | ||
| using System.Globalization; | ||
|
|
||
| namespace Files.App.Data.Contracts | ||
| { | ||
| /// <summary> | ||
| /// Provides an interface for managing real-time layout updates and related operations. | ||
| /// </summary> | ||
| public interface IRealTimeLayoutService | ||
| { | ||
| /// <summary> | ||
| /// Gets the current flow direction for layout (e.g., LeftToRight or RightToLeft). | ||
| /// </summary> | ||
| FlowDirection FlowDirection { get; } | ||
|
|
||
| /// <summary> | ||
| /// Adds a callback to be executed when a specific target requires updates. | ||
| /// </summary> | ||
| /// <param name="target">The target object for which the callback is registered.</param> | ||
| /// <param name="callback">The action to execute during updates.</param> | ||
| void AddCallback(object target, Action callback); | ||
|
|
||
| /// <summary> | ||
| /// Updates the content layout of the specified framework element. | ||
| /// </summary> | ||
| /// <param name="frameworkElement">The framework element to update.</param> | ||
| void UpdateContent(FrameworkElement frameworkElement); | ||
|
|
||
| /// <summary> | ||
| /// Updates the content layout of the specified window. | ||
| /// </summary> | ||
| /// <param name="window">The window whose content layout needs updating.</param> | ||
| void UpdateContent(Window window); | ||
|
|
||
| /// <summary> | ||
| /// Updates the culture settings for the layout. | ||
| /// </summary> | ||
| /// <param name="culture">The culture information to apply.</param> | ||
| void UpdateCulture(CultureInfo culture); | ||
|
|
||
| /// <summary> | ||
| /// Updates the title bar of the specified window. | ||
| /// </summary> | ||
| /// <param name="window">The window whose title bar needs updating.</param> | ||
| /// <returns>True if the title bar was successfully updated; otherwise, false.</returns> | ||
| bool UpdateTitleBar(Window window); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright (c) 2024 Files Community | ||
| // Licensed under the MIT License. See the LICENSE. | ||
|
|
||
| namespace Files.App.Data.Contracts | ||
| { | ||
| /// <summary> | ||
| /// Defines an interface for real-time window components that manage content layout updates. | ||
| /// </summary> | ||
| internal interface IRealTimeWindow | ||
| { | ||
| /// <summary> | ||
| /// Initializes the content layout for the window. | ||
| /// </summary> | ||
| void InitializeContentLayout() { } | ||
XTorLukas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| /// <summary> | ||
| /// Updates the content layout of the window. | ||
| /// </summary> | ||
| void UpdateContentLayout() { } | ||
XTorLukas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.