Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Dec 15, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  • Unpin Recycle Bin from the sidebar
  • Create 25,000 blank text files from cmd line
  • Delete all of the files via File Explorer
  • Go back to Files and delete a single file, verify that the app does NOT stop responding
  • Pin Recycle Bin to the sidebar again and restart Files and verify that the app does NOT stop responding

@gave92 gave92 added the ready for review Pull requests that are ready for review label Dec 15, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 15, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where app stops responding if there are a lot of items in Recycle Bin Fix: Resolved startup freeze issue caused by a heavily populated Recycle Bin Dec 15, 2024
@yaira2 yaira2 merged commit af51d81 into files-community:main Dec 16, 2024
6 checks passed
@gave92 gave92 deleted the issue_14108 branch December 16, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: App stops responding if there are a lot of items in Recycle Bin

2 participants