Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented Dec 16, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Set a folder in column view mode
  2. Right click on empty space, check it does not crash

@gave92 gave92 changed the title Hide tooltip to prevent crash on oem keys Fix: Fixed an issue causing crash when opening context menu in column view Dec 16, 2024
@gave92 gave92 added the ready for review Pull requests that are ready for review label Dec 16, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed an issue causing crash when opening context menu in column view Fix: Fixed a crash in the Column Layout context menu Dec 17, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 17, 2024
@yaira2 yaira2 merged commit 5a4c7c0 into files-community:main Dec 17, 2024
6 checks passed
@gave92 gave92 deleted the issue_16193 branch December 17, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Right clicking column layout crashes app

2 participants