From 22ef0f1b4b6143d6e568bbb6276455e52d1f4ae7 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Sun, 12 Jan 2025 17:23:10 +0000 Subject: [PATCH 1/5] Add a full stop at the end of CQ issue template description --- .github/ISSUE_TEMPLATE/code_quality_issue.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/code_quality_issue.yml b/.github/ISSUE_TEMPLATE/code_quality_issue.yml index b1613fa819b7..ecd0fbbcdde9 100644 --- a/.github/ISSUE_TEMPLATE/code_quality_issue.yml +++ b/.github/ISSUE_TEMPLATE/code_quality_issue.yml @@ -1,5 +1,5 @@ name: Code Quality Issue -description: Create a code quality issue to help Files keep a clean codebase +description: Create a code quality issue to help Files keep a clean codebase. type: 'Code quality' title: 'Code Quality: ' body: From 2f8a7e40f4a0eeadb10fbd5687cc103f9e8b5865 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Sun, 12 Jan 2025 17:24:36 +0000 Subject: [PATCH 2/5] Remove OS version from feature request Not really necessary --- .github/ISSUE_TEMPLATE/feature_request.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 31ea2d803bad..b31f0d4ada9c 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -49,16 +49,6 @@ body: validations: required: true - # Windows Version - - type: input - id: windows_version - attributes: - label: Windows Version - description: Which version of Windows are you using? To copy your Windows version, access it from Settings -> About -> Copy -> Windows version. - placeholder: "e.g. 10.0.22621.1848" - validations: - required: true - # Additional Comments - type: textarea attributes: From 7fcc58d9bb92fe97224b06c4629c685ad55f64cd Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Sun, 12 Jan 2025 17:26:03 +0000 Subject: [PATCH 3/5] Make tip about requirements more concise --- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index b31f0d4ada9c..d1f5e80598ff 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -25,7 +25,7 @@ body: value: | --- - Please include a list changes required to make this improvement. A good rule of thumb is to start your proposal with no more than 7 high-level requirements. + What will need to change in order for this feature to be implemented? A good rule of thumb is to start your proposal with no more than 7 high-level requirements. # Requirements - type: textarea From 6ce3e9255660d5599434f18d362a79796d94c459 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Sun, 12 Jan 2025 17:30:33 +0000 Subject: [PATCH 4/5] Add space --- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index d1f5e80598ff..5094d1f64778 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -9,7 +9,7 @@ body: attributes: value: | > [!TIP] - >Have you checked for similar feature requests? There's a possibility your suggestion is already being tracked. Please do a thorough search before creating a new issue. + > Have you checked for similar feature requests? There's a possibility your suggestion is already being tracked. Please do a thorough search before creating a new issue. # Description - type: textarea From 58e6ad52568c997049f10b95cf3eca887cf5e6a3 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Sun, 12 Jan 2025 17:34:45 +0000 Subject: [PATCH 5/5] Hide unnecessary elements in PR template and add description section --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 96c94cd49424..409b8f4559ed 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,12 +8,23 @@ I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: **Resolved / Related Issues** -To prevent extra work, all changes to the Files codebase must link to an approved issue marked as `Ready to build`. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves. + + - Closes # **Steps used to test these changes** -Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR. + 1. Opened Files ... 2. ... + +--- + +