Skip to content

Feature: Added a comparison text box for hashes #16771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Mar 21, 2025
Merged

Feature: Added a comparison text box for hashes #16771

merged 37 commits into from
Mar 21, 2025

Conversation

@Lamparter
Copy link
Contributor

@Lamparter Lamparter commented Feb 2, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Opened properties of a file
  3. Navigated to "hashes" tab
  4. New functionality!

@Lamparter Lamparter force-pushed the hashprop branch 2 times, most recently from 972d43f to 27dec66 Compare February 16, 2025 08:35
@Lamparter Lamparter force-pushed the hashprop branch 2 times, most recently from 7a1298b to 7260e7a Compare March 2, 2025 19:24
yaira2
yaira2 reviewed Mar 3, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 3, 2025
View reviewed changes
@Lamparter Lamparter marked this pull request as ready for review March 3, 2025 17:09
Lamparter
Lamparter commented Mar 3, 2025
View reviewed changes
Copy link
Contributor Author

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes on behalf of @0x5bfa

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 3, 2025
yaira2
yaira2 reviewed Mar 4, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 4, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 4, 2025
View reviewed changes
@Lamparter Lamparter force-pushed the hashprop branch 2 times, most recently from 416a277 to a4775f4 Compare March 16, 2025 17:57
yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 16, 2025
View reviewed changes
@Lamparter Lamparter requested a review from yaira2 March 17, 2025 19:17
yaira2
yaira2 reviewed Mar 17, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 17, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 17, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 17, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
yaira2
yaira2 reviewed Mar 18, 2025
View reviewed changes
Lamparter and others added 12 commits March 20, 2025 11:34
@Lamparter @yaira2
Remove XAML behaviours command
07bbccb 
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
@Lamparter @yaira2
SHA384 -> MD5
eb3712a 
[skip ci]
@Lamparter @yaira2
Convert ItemsSource to OneWay binding
bcea388
@Lamparter @yaira2
Fix info bar appearing in file comparison
9b82e7d
@Lamparter @yaira2
Leftover changes
40a5e2e
@Lamparter @yaira2
Apply suggestions from code review
926d757 
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
@Lamparter @yaira2
Fix for the compare file feature
0dbc80b 
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
@Lamparter @yaira2
Apply suggestions from code review
404684e 
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
@yaira2
Update src/Files.App/ViewModels/Properties/HashesViewModel.cs
ffbf07d 
Signed-off-by: Yair <[email protected]>
@yaira2
Update src/Files.App/ViewModels/Properties/HashesViewModel.cs
90b8806 
Signed-off-by: Yair <[email protected]>
@yaira2
Update HashesViewModel.cs
94a9608
@Lamparter @yaira2
Remove SelectAlgorithm entry from Resources.resw
16789ff
yaira2
yaira2 reviewed Mar 20, 2025
View reviewed changes
yaira2
yaira2 previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 20, 2025
0x5bfa
0x5bfa suggested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@Lamparter Lamparter requested a review from yaira2 March 21, 2025 07:45
@yaira2 yaira2 merged commit cec20ff into files-community:main Mar 21, 2025
5 checks passed
@Lamparter Lamparter deleted the hashprop branch March 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 Awaiting requested review from yaira2

1 more reviewer

@0x5bfa 0x5bfa 0x5bfa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Add a comparison text box for hashes

3 participants

@Lamparter @yaira2 @0x5bfa