Skip to content

Code Quality: Enforced centralized Strings class in global actions #16937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lamparter wants to merge 1 commit into from
Closed

Code Quality: Enforced centralized Strings class in global actions #16937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/EditPathAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed class EditPathAction : IAction
private readonly IContentPageContext context;

public string Label
=> "EditPath".GetLocalizedResource();
=> Strings.EditPath.GetLocalizedResource();

public string Description
=> "EditPathDescription".GetLocalizedResource();
=> Strings.EditPathDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.L, KeyModifiers.Ctrl);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/EnterCompactOverlayAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ internal sealed partial class EnterCompactOverlayAction : ObservableObject, IAct
private readonly IWindowContext windowContext;

public string Label
=> "EnterCompactOverlay".GetLocalizedResource();
=> Strings.EnterCompactOverlay.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.CompactOverlay");
Expand All @@ -20,7 +20,7 @@ public HotKey HotKey
=> new(Keys.Up, KeyModifiers.CtrlAlt);

public string Description
=> "EnterCompactOverlayDescription".GetLocalizedResource();
=> Strings.EnterCompactOverlayDescription.GetLocalizedResource();

public bool IsExecutable
=> !windowContext.IsCompactOverlay;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/ExitCompactOverlayAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ internal sealed partial class ExitCompactOverlayAction : ObservableObject, IActi
private readonly IWindowContext windowContext;

public string Label
=> "ExitCompactOverlay".GetLocalizedResource();
=> Strings.ExitCompactOverlay.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.CompactOverlayExit");
Expand All @@ -19,7 +19,7 @@ public HotKey HotKey
=> new(Keys.Down, KeyModifiers.CtrlAlt);

public string Description
=> "ExitCompactOverlayDescription".GetLocalizedResource();
=> Strings.ExitCompactOverlayDescription.GetLocalizedResource();

public bool IsExecutable
=> windowContext.IsCompactOverlay;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/OpenHelpAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ namespace Files.App.Actions
internal sealed class OpenHelpAction : IAction
{
public string Label
=> "Help".GetLocalizedResource();
=> Strings.Help.GetLocalizedResource();

public string Description
=> "OpenHelpDescription".GetLocalizedResource();
=> Strings.OpenHelpDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.F1);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/RedoAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class RedoAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Redo".GetLocalizedResource();
=> Strings.Redo.GetLocalizedResource();

public string Description
=> "RedoDescription".GetLocalizedResource();
=> Strings.RedoDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.Y, KeyModifiers.Ctrl);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/SearchAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class SearchAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Search".GetLocalizedResource();
=> Strings.Search.GetLocalizedResource();

public string Description
=> "SearchDescription".GetLocalizedResource();
=> Strings.SearchDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.F, KeyModifiers.Ctrl);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/ToggleCompactOverlayAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ internal sealed partial class ToggleCompactOverlayAction : ObservableObject, ITo
private readonly IWindowContext windowContext;

public string Label
=> "ToggleCompactOverlay".GetLocalizedResource();
=> Strings.ToggleCompactOverlay.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.F12);

public string Description
=> "ToggleCompactOverlayDescription".GetLocalizedResource();
=> Strings.ToggleCompactOverlayDescription.GetLocalizedResource();

public bool IsOn
=> windowContext.IsCompactOverlay;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/ToggleFullScreenAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ namespace Files.App.Actions
internal sealed class ToggleFullScreenAction : IToggleAction
{
public string Label
=> "FullScreen".GetLocalizedResource();
=> Strings.FullScreen.GetLocalizedResource();

public string Description
=> "ToggleFullScreenDescription".GetLocalizedResource();
=> Strings.ToggleFullScreenDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.F11);
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Global/UndoAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class UndoAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Undo".GetLocalizedResource();
=> Strings.Undo.GetLocalizedResource();

public string Description
=> "UndoDescription".GetLocalizedResource();
=> Strings.UndoDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.Z, KeyModifiers.Ctrl);
Expand Down
Loading