Skip to content

Code Quality: Disable opening context menu on footer items #16995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Code Quality: Disable opening context menu on footer items #16995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App.Controls/Sidebar/SidebarView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
HorizontalAlignment="Stretch"
VerticalAlignment="Stretch"
Canvas.ZIndex="10"
ContextRequested="PaneColumnGrid_ContextRequested"
XYFocusKeyboardNavigation="Enabled">
<Grid.RowDefinitions>
<RowDefinition Height="*" />
Expand All @@ -63,6 +62,7 @@
<ScrollViewer
x:Name="MenuItemHostScrollViewer"
Padding="0,8,0,0"
ContextRequested="MenuItemHostScrollViewer_ContextRequested"
HorizontalScrollMode="Disabled"
VerticalScrollBarVisibility="Auto"
XYFocusKeyboardNavigation="Enabled">
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App.Controls/Sidebar/SidebarView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ private void SidebarResizer_ManipulationCompleted(object sender, ManipulationCom
e.Handled = true;
}

private void PaneColumnGrid_ContextRequested(UIElement sender, ContextRequestedEventArgs e)
private void MenuItemHostScrollViewer_ContextRequested(UIElement sender, ContextRequestedEventArgs e)
{
var newArgs = new ItemContextInvokedArgs(null, e.TryGetPosition(this, out var point) ? point : default);
ViewModel.HandleItemContextInvokedAsync(this, newArgs);
Expand Down
Loading