Code Quality: Refactored StorageRing/StorageBar #16998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-StorageControls
branch
2 times, most recently
from
070f6c7 to
0db5911
Compare
0x5bfa
force-pushed
the
5bfa/CQ-StorageControls
branch
from
0db5911 to
04a753c
Compare
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
This fixes an issue in the app where the XAML visual wasnt applied to these controls because the required theme resources werent set to Generic.xaml
Steps used to test these changes
Since there was a layout cycle crash in the Tests app, I fixed it by moving the default controls into another sample panel.
