Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 6, 2025

Resolved / Related Issues

Steps used to test these changes

  1. Open Files app
  2. Test logical drives
    1. Click on one of them
    2. Right click on a drive
    3. See if the Eject option shows up for removal drives and CD ROM storage
    4. Try other menu flyout items
  3. Test network locations
    1. Click on one of them
    2. Right click on one of them
    3. Try menu flyout items of them

@0x5bfa 0x5bfa changed the title Code Quality: Simplified loading of logical drives and network location in the Home widges Code Quality: Simplified loading of logical drives and network locations in the Home widges May 6, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Drives branch from 6a8e8b1 to 6fadea0 Compare May 6, 2025 19:43
flyout!.Closed += flyoutClosed;
}

private void ExecuteDisconnectNetworkDriveCommand(WidgetDriveCardItem? item)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this command not being used? If it's not, we should look at the commit history to see what happened.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thought the same. I'll look into.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x5bfa 0x5bfa closed this Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants